Problem

The createWorkspace.spec.ts e2e tests have been experiencing flakiness, causing intermittent failures in CI. After investigation, I identified several race conditions and timing issues in the test helpers.

Root Causes

1. Race conditions in disableDynamicParameters function:

   • Used domcontentloaded instead of networkidle for page loading
   • Didn't wait for checkbox visibility before checking state
   • Fragile success message selector
   • No timeout buffers for UI state changes

2. Timing issues in createWorkspace function:

   • Used domcontentloaded instead of networkidle
   • No wait for form readiness before filling parameters

3. Insufficient waits in fillParameters function:

   • No explicit timeout on parameter field selectors

Solution

Enhanced disableDynamicParameters Function

• ✅ Use networkidle for better page loading
• ✅ Add explicit waits for form and checkbox visibility
• ✅ Use more robust selectors for success messages ([role='alert'], .MuiAlert-root, text=Template updated successfully)
• ✅ Add timeout buffers for UI state changes
• ✅ Increase timeout to 15 seconds for success message

Improved createWorkspace Function

• ✅ Use networkidle for more reliable page loading
• ✅ Add form readiness check before filling parameters
• ✅ Add 500ms timeout buffer for form element rendering

Enhanced fillParameters Function

• ✅ Add explicit 10-second timeout to parameter field selectors

Testing

To verify these fixes work, run the tests multiple times:

# Run the specific test file 5 times to check for flakiness
pnpm run playwright:test createWorkspace.spec.ts --repeat-each=5

# Or run a specific test multiple times
pnpm run playwright:test createWorkspace.spec.ts -g "create workspace with default immutable parameters" --repeat-each=10

Expected Impact

These changes should significantly reduce test flakiness by:

• Ensuring all UI elements are fully loaded before interaction
• Adding proper waits for dynamic content
• Using more reliable page loading strategies
• Providing better error handling with explicit timeouts
• Adding stability buffers for UI state changes

The tests should now pass consistently across multiple runs without the race conditions that were causing intermittent failures.