fix(e2e): resolve race condition in template upload test #19072
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blink-so[bot]](https://avatars.githubusercontent.com/in/1271127?s=60&v=4){kind=small}
Fix flaky e2e test failure in autoCreateWorkspace.spec.ts by adding proper wait conditions after file upload in the createTemplate helper. The test was failing intermittently because it would immediately proceed to fill the form and submit after uploading a file, without waiting for the upload to complete. This caused the form submission to fail and the page to remain at /templates/new instead of navigating to the expected template files page. The fix adds explicit waits for: 1. Upload spinner (drop-zone) to disappear 2. Uploaded file name to appear in the UI This ensures the upload completes before proceeding with form submission, eliminating the race condition. Co-authored-by: jaaydenh <1858163+jaaydenh@users.noreply.github.com>
Update the wait conditions to properly detect when file upload is complete: - Wait for drop-zone to be detached (removed from DOM) instead of hidden - Use simpler text selector for the uploaded file name The previous selectors were incorrect because when upload completes, the drop-zone component is completely replaced with a file display UI. Co-authored-by: jaaydenh <1858163+jaaydenh@users.noreply.github.com>
Fix code formatting issues identified by biome linter: - Multi-line object formatting for waitForSelector calls - Consistent quote usage Co-authored-by: jaaydenh <1858163+jaaydenh@users.noreply.github.com>
Remove the problematic 'detached' state check and rely only on waiting for the uploaded file name to appear. This is more reliable and simpler. The 'detached' state might not work as expected in all Playwright versions, so using a single wait condition for the file name appearance is sufficient to ensure the upload has completed. Co-authored-by: jaaydenh <1858163+jaaydenh@users.noreply.github.com>
Replace waitForSelector with locator().filter().waitFor() for better reliability when waiting for the uploaded file name to appear. This approach is more specific and should work better with Playwright's modern API patterns. Co-authored-by: jaaydenh <1858163+jaaydenh@users.noreply.github.com>
CI Status UpdateThe current CI failures are unrelated to this fix. The failing tests are:
These are different tests in a different spec file ( The
The fix implemented here specifically addresses the race condition in the Summary of Fix✅ Root cause identified: Race condition in template creation The unrelated test failures should be addressed separately. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The e2e test
autoCreateWorkspace.spec.tswas failing intermittently with the error:This was caused by a race condition in the
createTemplatehelper function where the test would immediately proceed to fill the form and submit after uploading a file, without waiting for the upload to complete.Solution
Added explicit wait conditions after file upload in the
createTemplatehelper function:This ensures the file upload completes before proceeding with form submission, eliminating the race condition.
Testing
The fix addresses the specific timing issue that caused the test to be flaky. The test should now consistently pass by waiting for proper upload completion indicators.
Changes
site/e2e/helpers.tsto add wait conditions after file upload increateTemplatefunction