chore(agent/agentcontainers): skip part of test if on darwin
#19081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates to coder/internal#765 I've been unable to figure out how to fix this (unfortunately my macOS file system knowledge is lacking). Given that this test is causing a lot of flakes at the moment, I think it is best to skip this part of the test on macOS for now.
There was a problem hiding this comment.
Pull Request Overview
This PR addresses test flakiness on macOS by conditionally skipping the atomic rename portion of a file system watcher test when running on Darwin (macOS). The change is intended as a temporary workaround for unreliable test behavior on macOS file systems while the underlying issue is investigated.
- Adds runtime OS detection to skip problematic test section on macOS
- Includes detailed TODO comment explaining the reasoning and context
- Maintains full test coverage on Linux systems where the feature is actually used
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
johnstcn
approved these changes
Jul 29, 2025
mtojek
approved these changes
Jul 29, 2025
| // for our dev container integration. We do not expect the host workspace | ||
| // (where this is used), to ever be run on macOS, as containers are a linux | ||
| // paradigm. | ||
| if runtime.GOOS != "darwin" { |
There was a problem hiding this comment.
nit: maybe fail-fast approach?
if runtime.GOOS == "darwin" {
err = wut.Remove(testFile)
require.NoError(t, err, "remove file from watcher failed")
return
}There was a problem hiding this comment.
Apologies, I hit the green button a little quick.
I can see the benefit to the suggestion, although I think I prefer indenting the flakey code instead as this isn't a permanent change.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to coder/internal#765
I've been unable to figure out how to fix this (unfortunately my macOS file system knowledge is lacking). Given that this test is causing a lot of flakes at the moment, I think it is best to skip this part of the test on macOS for now.