Content-Length: 290088 | pFad | http://github.com/coder/coder/pull/19087

52 fix(site): remove redundant alt text to prevent duplicated accessible names by ssncferreira · Pull Request #19087 · coder/coder · GitHub
Skip to content

fix(site): remove redundant alt text to prevent duplicated accessible names #19087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ssncferreira
Copy link
Contributor

Description

Removes the redundant alt text in the Combobox component to prevent screen readers from announcing duplicated names (e.g. "Rust Rust").

Changes

  • Remove redundant alt text from Combobox ExternalImage
  • Update Combobox tests accordingly

Related to: #19063 (comment)

@ssncferreira ssncferreira marked this pull request as ready for review July 29, 2025 18:14
@ssncferreira ssncferreira requested a review from Parkreiner July 29, 2025 18:14
Copy link
Member

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for fixing this 🙏

Copy link
Member

@aslilac aslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/coder/coder/pull/19087

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy