chore: move port forwarding out of cli package #19092
Open
+522
−298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
reviewed
Jul 29, 2025
ibetitsmike
changed the title
ibetitsmike
force-pushed
the
mike/port-forwarding
branch
from
fb745d4 to
7512819
Compare
|
Definitely, I've removed the protobuf changes from this PR. |
johnstcn
approved these changes
Jul 30, 2025
Comment on lines
+41
to
+45
| AddForward(spec Spec) (Forwarder, error) | ||
| // RemoveForward removes an existing port forward. | ||
| RemoveForward(spec Spec) error | ||
| // ListForwards returns all active port forwards. | ||
| ListForwards() []Forwarder |
There was a problem hiding this comment.
nit: you could remove the Forward suffix from these method names for brevity
Comment on lines
+80
to
+85
| func NewForwarder(spec Spec, opts Options) Forwarder { | ||
| return &localForwarder{ | ||
| spec: spec, | ||
| opts: opts, | ||
| } | ||
| } |
There was a problem hiding this comment.
suggest NewLocal() instead and returning a *LocalForwarder. Proverb: "accept interfaces, return structs"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the initial work needed for hosting the port forwarding capabilities both from the vpn tunnel package and cli instead of having the logic duplicated.