Content-Length: 272502 | pFad | http://github.com/coder/coder-jetbrains-toolbox/pull/164

C2 impl: strict URL validation by fioan89 · Pull Request #164 · coder/coder-jetbrains-toolbox · GitHub
Skip to content

impl: strict URL validation #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

impl: strict URL validation #164

wants to merge 1 commit into from
+134 −6

Conversation

fioan89
Copy link
Collaborator

@fioan89 fioan89 commented Jul 28, 2025

This commit rejects any URL that is opaque, not hierarchical, not using http or https protocol, or it misses the hostname. The rejection is handled in the connection/auth screen and also in the URI protocol handling logicimage
image
image

@fioan89
impl: strict URL validation
82a8590 
This commit rejects any URL that is opaque, not hierarchical, not using http or https
protocol, or it misses the hostname. The rejection is handled in the connection/auth screen
and also in the URI protocol handling logic.
matifali
matifali reviewed Jul 29, 2025
View reviewed changes
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we make the error message a bit more explicit with an example of a correct URL? I think some of the users may not know what an opaque or hierarchical URL is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matifali matifali matifali left review comments

@f0ssel f0ssel Awaiting requested review from f0ssel

@jdomeracki-coder jdomeracki-coder Awaiting requested review from jdomeracki-coder

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fioan89 @matifali








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/coder/coder-jetbrains-toolbox/pull/164

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy