Content-Length: 395193 | pFad | http://github.com/cri-o/cri-o/pull/8508

0C [WIP] Test irqbalance mask logic with 512 cpus by MarSik · Pull Request #8508 · cri-o/cri-o · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Test irqbalance mask logic with 512 cpus #8508

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[WIP] Test irqbalance mask logic with 512 cpus #8508

wants to merge 1 commit into from

Conversation

MarSik
Copy link
Contributor

@MarSik MarSik commented Aug 21, 2024

What type of PR is this?

/kind ci

What this PR does / why we need it:

New AMD Genoa and Bergamo based machines can have up-to 512 threads in dual socket configurations. This test will make sure the interrupt balancing logic computes proper masks for those.

Which issue(s) this PR fixes:

Special notes for your reviewer:

This is a draft atm.

Does this PR introduce a user-facing change?

None

@MarSik MarSik requested a review from mrunalp as a code owner August 21, 2024 09:28
@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: no Indicates the PR's author has not DCO signed all their commits. kind/ci Categorizes issue or PR as related to CI labels Aug 21, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 21, 2024

Hi @MarSik. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 21, 2024
@kwilczynski
Copy link
Member

@MarSik, we also have the following pending merge:

Curtesy of @ffromani.

@kwilczynski
Copy link
Member

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 21, 2024
@kwilczynski kwilczynski changed the title WIP Test irqbalance mask logic with 512 cpus [WIP] Test irqbalance mask logic with 512 cpus Aug 21, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.08%. Comparing base (c956013) to head (051352f).
Report is 70 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8508      +/-   ##
==========================================
- Coverage   47.09%   47.08%   -0.01%     
==========================================
  Files         154      154              
  Lines       22138    22138              
==========================================
- Hits        10425    10424       -1     
- Misses      10644    10645       +1     
  Partials     1069     1069

@kwilczynski
Copy link
Member

@MarSik, you also need to add the "Signed-off-by" tag to your commits for the DCO bit.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

A friendly reminder that this PR had no activity for 30 days.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 2, 2024
@kwilczynski kwilczynski removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2024

A friendly reminder that this PR had no activity for 30 days.

@github-actions github-actions bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

A friendly reminder that this PR had no activity for 30 days.

@github-actions github-actions bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2025

A friendly reminder that this PR had no activity for 30 days.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 4, 2025
@MarSik
Test irqbalance mask logic with 512 cpus
051352f 
This just improves tests to cover more complicated irqbalance
cpu layout scenarios.

Signed-off-by: Martin Sivak <msivak@redhat.com>
@openshift-ci openshift-ci bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Jan 16, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MarSik
Once this PR has been reviewed and has the lgtm label, please assign haircommander for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 16, 2025

@MarSik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-cgroupv2-integration 051352f link true /test ci-cgroupv2-integration
ci/prow/ci-fedora-kata 051352f link true /test ci-fedora-kata

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 17, 2025
@github-actions GitHub Actions
Copy link

A friendly reminder that this PR had no activity for 30 days.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@hasan4791 hasan4791 Awaiting requested review from hasan4791

@sohankunkerkar sohankunkerkar Awaiting requested review from sohankunkerkar

Assignees

@MarSik MarSik

Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/ci Categorizes issue or PR as related to CI lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarSik @kwilczynski








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/cri-o/cri-o/pull/8508

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy