dependency: Update Electron to 34 #31260
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CloneOfAlex
approved these changes
Mar 11, 2025
cypress
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
electron-34
|
| Run status |
|
| Run duration | 19m 53s |
| Commit |
|
| Committer | Cacie Prins |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
7
|
Flaky
|
1
|
Pending
|
29
|
Skipped
|
0
|
Passing
|
785
|
| View all changes introduced in this branch ↗︎ | |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage
63.64%
|
|
|---|---|
|
Untested elements
|
30
|
|
Tested elements
|
56
|
Accessibility
96.23%
|
|
|---|---|
|
Failed rules
|
0 critical
4 serious
1 moderate
0 minor
|
|
Failed elements
|
143
|
Tests for review
cypress\e2e\studio\studio.cy.ts • 3 failed tests • app-e2e
cypress\e2e\config-files-error-handling.cy.ts • 1 failed test • launchpad-e2e
| Test | Artifacts | |
|---|---|---|
| Launchpad: Error System Tests > shows correct stack trace when config with ts-module error |
Test Replay
Screenshots
|
|
cypress\e2e\project-setup.cy.ts • 1 failed test • launchpad-e2e
| Test | Artifacts | |
|---|---|---|
| Launchpad: Setup Project > switch testing types > takes the user to first step of ct setup when switching from app |
Test Replay
Screenshots
|
|
cypress\e2e\error-handling.cy.ts • 2 failed tests • launchpad-e2e
| Test | Artifacts | |
|---|---|---|
| ... > automatically sources vite.config.js |
Test Replay
Screenshots
|
|
| ... > automatically sources webpack.config.js |
Test Replay
Screenshots
|
|
The first 5 failed specs are shown, see all 8 specs in Cypress Cloud.
cypress\e2e\specs_list_actual_git_repo.cy.ts • 1 flaky test • app-e2e
| Test | Artifacts | |
|---|---|---|
| Spec List - Last updated with git info > shows correct git icons |
Test Replay
Screenshots
|
|
jennifer-shehane
changed the title
CloneOfAlex
approved these changes
Mar 12, 2025
| @@ -279,6 +279,7 @@ | |||
| "@types/react": "18.3.12", | |||
| "browserify-sign": "4.2.2", | |||
| "devtools-protocol": "0.0.1413303", | |||
| "node-abi": "3.74.0", | |||
There was a problem hiding this comment.
See this note as to why this was necessary: https://github.com/cypress-io/cypress/pull/31260/files#diff-43831bef862964fca0c4c1b68381da0539c3892c9b356e7db2a19cf25cfc4295R90
| @@ -305,7 +305,8 @@ export class ProjectConfigIpc extends EventEmitter { | |||
| // If they've got TypeScript installed, we can use | |||
| // ts-node for CommonJS | |||
| // ts-node/esm for ESM | |||
| if (hasTypeScriptInstalled(this.projectRoot)) { | |||
| // If we're in a cy in cy project, we will handle registering typescript directly in the server entry point | |||
| if (!process.env.CYPRESS_INTERNAL_E2E_TESTING_SELF_PARENT_PROJECT && hasTypeScriptInstalled(this.projectRoot)) { | |||
There was a problem hiding this comment.
Electron must have changed something with their spawn call. We're unsure what, but when cy-in-cy all of this logic is unnecessary.
CloneOfAlex
approved these changes
Apr 2, 2025
cacieprins
changed the title
AtofStryker
requested changes
May 2, 2025
There was a problem hiding this comment.
Did we actually update electron? It looks to be on 33.2.1 still on this branch https://github.com/cypress-io/cypress/blob/electron-34/package.json#L144
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?