internal: (studio) force test re-run if watchForFileChanges: false
#31982
+168
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
studio-reload-file-watching-disabled
|
| Run status |
|
| Run duration | 19m 40s |
| Commit |
|
| Committer | Adam Stone-Lord |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
11
|
Pending
|
1103
|
Skipped
|
0
|
Passing
|
26514
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
45.14%
|
|
|---|---|
|
Untested elements
|
187
|
|
Tested elements
|
158
|
Accessibility
92.87%
|
|
|---|---|
|
Failed rules
|
4 critical
9 serious
2 moderate
2 minor
|
|
Failed elements
|
674
|
astone123
commented
Jul 9, 2025
| @@ -678,6 +669,8 @@ describe('studio functionality', () => { | |||
| it('remains in studio mode when the test name is changed on the file system and file watching is disabled', () => { | |||
| launchStudio({ cliArgs: ['--config', 'watchForFileChanges=false'] }) | |||
|
|
|||
| cy.findByTestId('record-button-recording').should('be.visible') | |||
There was a problem hiding this comment.
added these to try to reduce some flake with this spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
This PR updates the app to pass the
onTestFileChangefunction over to the cloud studio code through theaddSocketListenerscall. Then on the cloud side we can use this function instance to force a re-load of the file after we save it which will cause it to re-run even if the user has disabled file watching.Steps to test
Test with the cloud PR (it's merged into develop now so you can just test with develop)
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?