Content-Length: 345674 | pFad | http://github.com/databricks/automl/pull/165

62 [ML-50316] Refactor frequency_unit and frequency_quantity in automl runtime by Lanz-db · Pull Request #165 · databricks/automl · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML-50316] Refactor frequency_unit and frequency_quantity in automl runtime #165

Open
wants to merge 6 commits into
base: branch-0.2.20.7
Choose a base branch
from
Open

[ML-50316] Refactor frequency_unit and frequency_quantity in automl runtime #165

wants to merge 6 commits into from

Conversation

Lanz-db
Copy link

@Lanz-db Lanz-db commented Feb 27, 2025 •
edited
Loading

What is this PR about?
This PR is to refactor the usage of frequency_unit and frequency_quantity. In this PR, #162, we introduced frequency_quantity, which made the code less readable. So we proposed to have a dataclass to combine frequency_unit and frequency_quantity so that the code is better readable and it enables us to add validation logic easily.

The main changes are

  1. a new dataclass, called Frequency, which contains frequency_unit and frequency_quantity, and contains some validation logic
  2. change all usage of frequency_unit and frequency_quantity to Frequency
  3. modify all the related unit tests

How to test?

  • unit tests

@Lanz-db Lanz-db changed the base branch from main to branch-0.2.20.7 February 27, 2025 01:07
@Lanz-db Lanz-db marked this pull request as ready for review February 27, 2025 01:14
apeforest
apeforest reviewed Feb 27, 2025
View reviewed changes
Copy link

@apeforest apeforest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactoring. It does look much cleaner. LGTM overall, except for a few minor comments.

apeforest
apeforest approved these changes Feb 27, 2025
View reviewed changes
Copy link

@apeforest apeforest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM. Thank you for the refactoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeforest apeforest apeforest approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lanz-db @apeforest








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/databricks/automl/pull/165

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy