Content-Length: 466680 | pFad | http://github.com/discordjs/discord.js/pull/10613

C4 refactor(Emoji)!: make imageURL() change extension dynamically by Idris1401 · Pull Request #10613 · discordjs/discord.js · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(Emoji)!: make imageURL() change extension dynamically #10613

Merged
merged 11 commits into from
Jan 16, 2025
Merged

refactor(Emoji)!: make imageURL() change extension dynamically #10613

merged 11 commits into from
Jan 16, 2025

Conversation

Idris1401
Copy link
Contributor

@Idris1401 Idris1401 commented Nov 23, 2024 •
edited by almeidx
Loading

BREAKING CHANGE: The REST#emoji method now has a animated required parameter.

Please describe the changes this PR makes and why it should be merged:

I think it'd be better if Emoji#imageURL() changes the extension dynamically as others ...URL() functions.

Status and versioning classification:

  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

@Idris1401 Idris1401 requested a review from a team as a code owner November 23, 2024 19:06
@vercel Vercel
Copy link

vercel bot commented Nov 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2025 9:51am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2025 9:51am

@Jiralite Jiralite added this to the discord.js 15.0.0 milestone Nov 27, 2024
kyranet
kyranet previously requested changes Dec 9, 2024
View reviewed changes
packages/discord.js/src/structures/Emoji.js Outdated Show resolved Hide resolved
@Idris1401 Idris1401 requested a review from kyranet December 17, 2024 16:53
@Idris1401 Idris1401 requested a review from a team as a code owner January 2, 2025 15:00
@codecov Codecov
Copy link

codecov bot commented Jan 2, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.00%. Comparing base (5f7d335) to head (d22e2c7).
Report is 7 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #10613   +/-   ##
=======================================
  Coverage   38.00%   38.00%           
=======================================
  Files         239      239           
  Lines       14894    14894           
  Branches     1389     1390    +1     
=======================================
  Hits         5661     5661           
  Misses       9221     9221           
  Partials       12       12
Flag Coverage Δ
proxy 64.63% <ø> (ø)
rest 87.33% <100.00%> (ø)
ws 34.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Idris1401 Idris1401 requested a review from almeidx January 2, 2025 15:12
@Idris1401
Copy link
Contributor Author

idk if the docs/typings for BaseGuildEmoji#imageURL() should also be updated or no

@Idris1401 Idris1401 requested a review from almeidx January 11, 2025 11:40
almeidx
almeidx requested changes Jan 11, 2025
View reviewed changes
packages/rest/src/lib/CDN.ts Outdated Show resolved Hide resolved
@Idris1401 Idris1401 requested a review from almeidx January 11, 2025 12:39
@almeidx almeidx changed the title refactor(Emoji)!: make imageURL() changing extension dynamically refactor(Emoji)!: make imageURL() change extension dynamically Jan 13, 2025
Jiralite
Jiralite previously requested changes Jan 13, 2025
View reviewed changes
Copy link
Member

@Jiralite Jiralite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests need updating! The second parameter of emoji() in REST is no longer an object, but it still is in the tests.

@almeidx almeidx requested a review from Jiralite January 15, 2025 16:38
@Jiralite Jiralite self-assigned this Jan 15, 2025
@Jiralite Jiralite removed this from the discord.js 15.0.0 milestone Jan 16, 2025
@Jiralite Jiralite merged commit 0c40bc1 into discordjs:main Jan 16, 2025
24 checks passed
@Idris1401 Idris1401 deleted the refactor-emoji branch January 16, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almeidx almeidx almeidx approved these changes

@Jiralite Jiralite Jiralite approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@kyranet kyranet Awaiting requested review from kyranet

@ckohen ckohen Awaiting requested review from ckohen ckohen is a code owner automatically assigned from discordjs/rest

@didinele didinele Awaiting requested review from didinele didinele is a code owner automatically assigned from discordjs/rest

Assignees

@Jiralite Jiralite

Labels
packages:discord.js packages:rest semver:major
Projects
discord.js
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Idris1401 @vladfrangu @kyranet @SpaceEEC @Jiralite @almeidx








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/discordjs/discord.js/pull/10613

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy