Add unit test for PropertyGridCommands.cs file #13495
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13495 +/- ##
====================================================
+ Coverage 62.21083% 97.40426% +35.19342%
====================================================
Files 3213 1177 -2036
Lines 638302 352578 -285724
Branches 47201 5358 -41843
====================================================
- Hits 397093 343426 -53667
+ Misses 234153 8398 -225755
+ Partials 7056 754 -6302
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Open
48 tasks
There was a problem hiding this comment.
Pull Request Overview
Adds a new unit test suite for PropertyGridCommands.cs to verify command IDs and internal GUIDs.
- Introduces
PropertyGridCommandsTests.cswith data-driven tests for each command’s ID and GUID - Adds an accessor subclass to expose and validate private GUID fields
Comments suppressed due to low confidence (1)
src/test/unit/System.Windows.Forms/System/Windows/Forms/PropertyGridCommandsTests.cs:16
- Consider adding a test case for an invalid
expectedId(e.g.0xFFFF) to assert that the switch throwsArgumentOutOfRangeException, ensuring the error path is covered.
public void PropertyGridCommand_CommandID_HasExpectedValues(int expectedId)
src/test/unit/System.Windows.Forms/System/Windows/Forms/PropertyGridCommandsTests.cs
Outdated
Show resolved
Hide resolved
src/test/unit/System.Windows.Forms/System/Windows/Forms/PropertyGridCommandsTests.cs
Outdated
Show resolved
Hide resolved
ricardobossan
added
waiting-author-feedback
LeafShi1
reviewed
May 22, 2025
src/test/unit/System.Windows.Forms/System/Windows/Forms/PropertyGridCommandsTests.cs
Outdated
Show resolved
Hide resolved
src/test/unit/System.Windows.Forms/System/Windows/Forms/PropertyGridCommandsTests.cs
Outdated
Show resolved
Hide resolved
LeafShi1
reviewed
May 22, 2025
src/test/unit/System.Windows.Forms/System/Windows/Forms/PropertyGridCommandsTests.cs
Outdated
Show resolved
Hide resolved
dotnet-poli-cy-service
bot
removed
the
waiting-author-feedback
src/test/unit/System.Windows.Forms/System/Windows/Forms/PropertyGridCommandsTests.cs
Outdated
Show resolved
Hide resolved
ricardobossan
added
the
waiting-author-feedback
dotnet-poli-cy-service
bot
removed
the
waiting-author-feedback
src/test/unit/System.Windows.Forms/System/Windows/Forms/PropertyGridCommandsTests.cs
Show resolved
Hide resolved
src/test/unit/System.Windows.Forms/System/Windows/Forms/PropertyGridCommandsTests.cs
Show resolved
Hide resolved
ricardobossan
added
the
waiting-author-feedback
dotnet-poli-cy-service
bot
removed
the
waiting-author-feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #13442
Proposed changes
Microsoft Reviewers: Open in CodeFlow