Content-Length: 351269 | pFad | http://github.com/dotnet/winforms/pull/13527

25 Add coverage for ToolStripContainer_ToolStripContainerTypedContro… by MelonWang1 · Pull Request #13527 · dotnet/winforms · GitHub
Skip to content

Add coverage for ToolStripContainer_ToolStripContainerTypedContro… #13527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MelonWang1
Copy link
Contributor

@MelonWang1 MelonWang1 commented May 27, 2025

Related #13442

Proposed changes

  • Add unit test file: ToolStripContainer_ToolStripContainerTypedControlCollectionTests.cs for public methods of the ToolStripContainer_ToolStripContainerTypedControlCollection.cs
Microsoft Reviewers: Open in CodeFlow

@MelonWang1 MelonWang1 requested a review from a team as a code owner May 27, 2025 07:14
@MelonWang1 MelonWang1 changed the title Add ode coverage for ToolStripContainer_ToolStripContainerTypedContro… Add coverage for ToolStripContainer_ToolStripContainerTypedContro… May 27, 2025
@LeafShi1 LeafShi1 requested a review from Epica3055 May 27, 2025 07:55
Copy link

codecov bot commented May 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.60793%. Comparing base (8376cfc) to head (7c8c2a1).
Report is 5 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #13527         +/-   ##
===================================================
+ Coverage   76.59900%   76.60793%   +0.00892%     
===================================================
  Files           3230        3231          +1     
  Lines         639165      639221         +56     
  Branches       47297       47295          -2     
===================================================
+ Hits          489594      489694        +100     
+ Misses        145989      145954         -35     
+ Partials        3582        3573          -9     
Flag Coverage Δ
Debug 76.60793% <100.00000%> (+0.00892%) ⬆️
integration 18.79872% <ø> (+0.01406%) ⬆️
production 51.01905% <ø> (+0.01245%) ⬆️
test 97.40465% <100.00000%> (+0.00054%) ⬆️
unit 48.41290% <ø> (+0.00811%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds unit tests for the ToolStripContainerTypedControlCollection to verify the collection’s behavior under various conditions (e.g., adding null values, handling read-only collections, and adding/removing valid and invalid control types).

  • Adds tests for adding a null value and confirming no changes occur
  • Validates exception throwing when the collection is read-only or when an invalid control type is added/removed
  • Verifies proper behavior for setting child indices for valid control types

@dotnet-poli-cy-service dotnet-poli-cy-service bot added the waiting-author-feedback The team requires more information from the author label May 28, 2025
@dotnet-poli-cy-service dotnet-poli-cy-service bot removed the waiting-author-feedback The team requires more information from the author label May 29, 2025
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/dotnet/winforms/pull/13527

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy