Fix 13227: Update SetName of DesignerExtenders.NameExtenderProvider to virtual method #13558
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeafShi1
requested review from
Copilot and
JeremyKuhne
and removed request for
a team
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the SetName method in DesignerExtenders.NameExtenderProvider from static to virtual to enable the Name property for all controls in DemoConsole.
- Changed SetName from static to virtual to support runtime polymorphism.
Comments suppressed due to low confidence (1)
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/DesignerExtenders.NameExtenderProvider.cs:91
- Changing SetName from static to virtual can impact existing callers that depend on static invocation. Verify that all usages of SetName are updated to appropriately handle instance-based calls.
public virtual void SetName(IComponent comp, string newName)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13558 +/- ##
===================================================
- Coverage 76.59927% 76.59677% -0.00250%
===================================================
Files 3230 3230
Lines 639151 639151
Branches 47295 47295
===================================================
- Hits 489585 489569 -16
- Misses 145994 146009 +15
- Partials 3572 3573 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
| @@ -88,7 +88,7 @@ public virtual bool CanExtend(object o) | |||
| //github.com/ This is an extender property that we offer to all components | |||
| //github.com/ on the form. It implements the "Name" property. | |||
| //github.com/ </summary> | |||
| public static void SetName(IComponent comp, string newName) | |||
| public virtual void SetName(IComponent comp, string newName) | |||
There was a problem hiding this comment.
We're using the Designer Extenders only internally. Are there "only" for testing support?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13227
Proposed changes
SetNameofDesignerExtenders.NameExtenderProviderfromstatictovirtualmethodCustomer Impact
Regression?
Risk
Screenshots
Before
In DemoConsole test app of WinForms repo,
Nameproperty for all controls is disabled.NET 10:
After
Nameproperty for all controls is enabledTest methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow