Interaction between markdown blockquotes and sections #11319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In an example (Fossies) I found the code like: ``` @page pg1 page > text ## section ``` and this results in the warning like: ``` warning: found </blockquote> tag without matching <blockquote> ``` so it is better to terminate the block quote when a potential section command appears
doxygen
reviewed
Jan 7, 2025
src/markdown.cpp
Outdated
| @@ -2854,6 +2854,9 @@ size_t Markdown::Private::writeBlockQuote(std::string_view data) | |||
| } | |||
| else | |||
| { | |||
| curLevel=level; | |||
| i = indent; | |||
| if (txt[0] == '#') break; // begin of markdown section command | |||
There was a problem hiding this comment.
looks like there is a risk we get here while txt is empty and since it is a string_view txt[0] can then trigger an out-of-bounds assert (on some systems).
There was a problem hiding this comment.
Indeed.
Solved some corner cases as well
> text
##NO header
##Second test on no header
and
> text
## text
After review better determination of Atx header. Solved some corner cases as well ``` > text ##NO header ##Second test on no header ``` and ``` > text ## text ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an example (package zlib_ng 2.2.3 on Fossies) I found the code like:
and this results in the warning like:
so it is better to terminate the block quote when a potential section command appears.
Example: example.tar.gz