Content-Length: 636611 | pFad | http://github.com/espnet/espnet/pull/5963

35 Speech enhancement baseline on the BinauralLibriSpeech data set by HolgerBovbjerg · Pull Request #5963 · espnet/espnet · GitHub
Skip to content

Speech enhancement baseline on the BinauralLibriSpeech data set #5963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

HolgerBovbjerg
Copy link

What?

Added a baseline experiment for speech enhancement on the BinauralLibriSpeech data set.

Why?

Adds an example experiment for using BinauralLibriSpeech data.

@mergify mergify bot added the ESPnet2 label Nov 22, 2024
@sw005320 sw005320 added the SE Speech enhancement label Nov 22, 2024
@sw005320 sw005320 added this to the v.202412 milestone Nov 22, 2024
@sw005320 sw005320 requested a review from Emrys365 November 22, 2024 19:45
Copy link
Collaborator

@Emrys365 Emrys365 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just went through the scripts. I think they are looking good. But I still left some comments above.

@Emrys365
Copy link
Collaborator

After reflecting the above comments, it is better to run the following command for style check of the shell scripts under egs2/binaural_librispeech/enh1/:

shellcheck -Calways -x -e SC2001 -e SC1091 -e SC2086 egs2/binaural_librispeech/enh1/local/*.sh

In addition, can you also add the information about the current corpus in egs2/README.md?

@mergify mergify bot added the README label Dec 11, 2024
@HolgerBovbjerg
Copy link
Author

HolgerBovbjerg commented Dec 11, 2024

All comments should be addressed.

  • Remove dead files
  • Added integrity checks
  • Shellcheck
  • rsync -> ln
  • Fix seed in noisy data generation

@sw005320
Copy link
Contributor

Cool!
There are some additional issues
https://github.com/espnet/espnet/actions/runs/12279617692/job/34264073517?pr=5963

@Emrys365
Copy link
Collaborator

To check the Python style issues, you can run the following command under directory:

pycodestyle --exclude "egs2/TEMPLATE/asr1/utils,egs2/TEMPLATE/asr1/steps,egs2/TEMPLATE/tts1/sid,doc,tools,test_utils/bats-core,test_utils/bats-support,test_utils/bats-assert" --show-source --show-pep8

@HolgerBovbjerg
Copy link
Author

It seems like the rest of the unsuccessful checks are unrelated to this PR?

@sw005320
Copy link
Contributor

You're right.
I'm checking to see if the exclusion of gun would fix the issue.
See #5982

Copy link

codecov bot commented Dec 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.20%. Comparing base (6318e10) to head (df161dd).
Report is 364 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (6318e10) and HEAD (df161dd). Click for more details.

HEAD has 12 uploads less than BASE
Flag BASE (6318e10) HEAD (df161dd)
test_python_espnet2 9 0
test_utils 3 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5963       +/-   ##
===========================================
- Coverage   56.06%   38.20%   -17.87%     
===========================================
  Files         830      566      -264     
  Lines       78031    51080    -26951     
===========================================
- Hits        43749    19515    -24234     
+ Misses      34282    31565     -2717     
Flag Coverage Δ
test_integration_espnetez 38.20% <ø> (+<0.01%) ⬆️
test_python_espnet2 ?
test_utils ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sw005320
Copy link
Contributor

Can you add a result to README.md with a model link?
Please follow the other recipes.

@sw005320
Copy link
Contributor

Can you add a result to README.md with a model link? Please follow the other recipes.

Can you revisit it?
This is not very heavy item.
Let's finish it.

@Fhrozen Fhrozen modified the milestones: v.202503, v.202506 Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/espnet/espnet/pull/5963

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy