Content-Length: 320131 | pFad | http://github.com/etf-validator/etf-webapp/pull/183

98 Cancel Start Test Run Error by carlospzurita · Pull Request #183 · etf-validator/etf-webapp · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancel Start Test Run Error #183

Closed
wants to merge 13 commits into from
Closed

Cancel Start Test Run Error #183

wants to merge 13 commits into from

Conversation

carlospzurita
Copy link
Contributor

José Luis García Sánchez and others added 13 commits April 23, 2018 13:54
Change repository location from etf-bsxds. Fixes etf-validator#131.
d344f69
@jlgarciasanchez
Merge pull request #1 from guadaltel/cosmetics/issue-131/skipped-colour
a1f033b 
Change repository location from etf-bsxds. Fixes etf-validator#131.
Add rerun button. Fixes etf-validator#62
7da2119
@jlgarciasanchez
Merge pull request #2 from guadaltel/enhancement/issue-62/add-rerun-b…
be4a7bf 
…utton

Add rerun button. Fixes etf-validator#62
Upgrade rerun function. Fixes etf-validator#62
63d72bd
@jlgarciasanchez
Merge pull request #3 from guadaltel/enhancement/issue-62/rerun-button
514c9f2 
Upgrade rerun function. Fixes etf-validator#62
build.gradle was modified in order to point at ii repository
6998231
Fixes sonar issues.
07bee7d
@jlgarciasanchez
Merge pull request #5 from guadaltel/debug/sonar
f7a87dd 
Fixes sonar issues.
@manmorjim
Merge branch 'next' of https://github.com/etf-validator/etf-webapp in…
178d037 
…to synch-fork
@jlgarciasanchez
Merge pull request #8 from guadaltel/synch-fork
0e1f25d 
Integrate the interactive instrument's changes.
Fix pull request etf-validator#158 issues.
51881ee
@carlospzurita
Fix redirection when closing the Configure Test Run dialogue. Related…
9aa440e 
… to community issue 13.
@cportele cportele self-requested a review December 20, 2018 14:06
cportele
cportele requested changes Dec 20, 2018
View reviewed changes
Copy link
Contributor

@cportele cportele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These edits are for several issues, not just the issue mentioned in the description. For example, the changes also include code for a rerun. Please submit a separate pull request for each issue, so we can review them separately. Thanks.

@carlospzurita
Copy link
Contributor Author

The other changes are the ones included in the pull request from 28th May #158

@cportele
Copy link
Contributor

Yes, and they should be reviewed and merged separately.

See https://github.com/etf-validator/governance/blob/master/TOR/PR_checklist.md:

Pull Request addresses only one concern

@cportele
Copy link
Contributor

... and please check that all other requirements from the checklist are met. Thank you.

@jonherrmann jonherrmann added the PR: ignore used to filter rejected / reopened Pull Requests label Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cportele cportele cportele requested changes

Assignees
No one assigned
Labels
PR: ignore used to filter rejected / reopened Pull Requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@carlospzurita @cportele @jonherrmann @jlgarciasanchez @manmorjim








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/etf-validator/etf-webapp/pull/183

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy