chore(fill): deprecate --flat-output flag #1632
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marioevz
approved these changes
May 20, 2025
src/pytest_plugins/filler/filler.py
Outdated
| @@ -132,7 +132,7 @@ def pytest_addoption(parser: pytest.Parser): | |||
| action="store_true", | |||
| dest="flat_output", | |||
| default=False, | |||
| help="Output each test case in the directory without the folder structure.", | |||
| help="[DEPRECATED] Output each test case in the directory without the folder structure. This flag will be removed in a future version.", | |||
There was a problem hiding this comment.
Suggested change
| help="[DEPRECATED] Output each test case in the directory without the folder structure. This flag will be removed in a future version.", | |
| help="[DEPRECATED] Output each test case in the directory without the folder structure. " | |
| "This flag will be removed in a future version.", |
Exceeds the character limit so the linter is going to complain.
richardgreg
force-pushed
the
deprecate-flat-output
branch
from
3eaadee to
dd40fdd
Compare
|
This feature's quite useful to diff individual fixtures. I'm not sure we should deprecate it so fast. |
Nevermind, I was thinking of |
Sounds good, I think just adding the warning is ok since it avoids someone else from relying on the flag if we eventually want to remove it. |
|
@marioevz is the failing CI test the fault of the implementation? Because I can't make a connection |
richardgreg
force-pushed
the
deprecate-flat-output
branch
from
dd40fdd to
2ea88d4
Compare
winsvega
suggested changes
May 23, 2025
winsvega
approved these changes
May 23, 2025
richardgreg
force-pushed
the
deprecate-flat-output
branch
from
2ea88d4 to
8b28697
Compare
- Added [DEPRECATED] to help message - Added runtime warning when flag is used - Updated documentation to indicate deprecation - Added entry to CHANGELOG.md"
richardgreg
force-pushed
the
deprecate-flat-output
branch
from
8b28697 to
20d03db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
🔗 Related Issues
Fixes #1603
✅ Checklist
mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.