Content-Length: 350067 | pFad | http://github.com/ethereum/execution-spec-tests/pull/1718

A9 feat(checklists): add `EIPChecklist` enum to specify EIP checklist items by marioevz · Pull Request #1718 · ethereum/execution-spec-tests · GitHub
Skip to content

feat(checklists): add EIPChecklist enum to specify EIP checklist items #1718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Jun 7, 2025

🗒️ Description

This PR introduces the EIPChecklist class which contains a list of all EIP checklist items for easier marking of tests that cover an item in the EIP checklist.

Calling any value in this class directly returns the marker which can be used in the tests or marks parameter of the parametrize object:

import pytest
from ethereum_test_tools import StateTestFiller
from ethereum_test_checklists import EIPChecklist

@EIPChecklist.TransactionType.Test.IntrinsicValidity.GasLimit.Exact()
def test_exact_intrinsic_gas(state_test: StateTestFiller):
    """Test transaction with exact intrinsic gas limit."""
    # Test implementation
    pass

It also fixes a breaking bug in the checklist generation code that marked all EIPs for a given test id when a marker was used anywhere in any test in any folder (whoops).

Suggestions for improvement of the usage of this new class are welcome.

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz requested a review from danceratopz June 7, 2025 13:41
@marioevz marioevz force-pushed the eip-checklist-enum branch from 36ad5a4 to 3ad8a32 Compare June 9, 2025 15:02
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nested classes are insane 😄 but LGTM, thanks!

@danceratopz danceratopz added type:feat type: Feature scope:fill Scope: fill command labels Jun 10, 2025
@danceratopz danceratopz changed the title feat(checklists): Add EIPChecklist enum to access EIP Checklist Items feat(checklists): add EIPChecklist enum to specify EIP checklist items Jun 10, 2025
@danceratopz danceratopz added the scope:checklists Scope: ethereum_test_checklists package label Jun 10, 2025
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something's not quite right when running fill.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:checklists Scope: ethereum_test_checklists package scope:fill Scope: fill command type:feat type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/ethereum/execution-spec-tests/pull/1718

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy