-
Notifications
You must be signed in to change notification settings - Fork 146
feat(checklists): add EIPChecklist
enum to specify EIP checklist items
#1718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
marioevz
wants to merge
13
commits into
main
Choose a base branch
from
eip-checklist-enum
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36ad5a4
to
3ad8a32
Compare
danceratopz
approved these changes
Jun 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The nested classes are insane 😄 but LGTM, thanks!
EIPChecklist
enum to access EIP Checklist ItemsEIPChecklist
enum to specify EIP checklist items
danceratopz
requested changes
Jun 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something's not quite right when running fill
.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
scope:checklists
Scope: ethereum_test_checklists package
scope:fill
Scope: fill command
type:feat
type: Feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
This PR introduces the
EIPChecklist
class which contains a list of all EIP checklist items for easier marking of tests that cover an item in the EIP checklist.Calling any value in this class directly returns the marker which can be used in the tests or
marks
parameter of the parametrize object:It also fixes a breaking bug in the checklist generation code that marked all EIPs for a given test id when a marker was used anywhere in any test in any folder (whoops).
Suggestions for improvement of the usage of this new class are welcome.
🔗 Related Issues
✅ Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.