Filter and Box Shadow Conversion Tests and Fixes #49418
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: We can reland this now that D69520832 update feature flags infra. Changelog: [Internal] Differential Revision: D69548370
Summary: We didn't have these cases before. Changlog: [Internal] Differential Revision: D69433955
Summary: I want to go home 😭. This is not pretty, but trying to keep the props data types undistutbed for now, and support some of the stranger syntax we ended up supporting as inputs to filters. Changelog: [Internal] Differential Revision: D69562718
Summary: This adds some missing validation for negative blurs which should be considered parse error, alongside a missing copy of inset state from CSSShadow to BoxShadow. Unit tests added for the forked props parsing code to validate more generally. Changelog: [Internal] Differential Revision: D69628917
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69628917 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This adds some missing validation for negative blurs which should be considered parse error, alongside a missing copy of inset state from CSSShadow to BoxShadow. Unit tests added for the forked props parsing code to validate more generally.
Changelog: [Internal]
Differential Revision: D69628917