Content-Length: 299347 | pFad | http://github.com/fastplotlib/fastplotlib/pull/410

A5 gpu info upon notebook import by kushalkolar · Pull Request #410 · fastplotlib/fastplotlib · GitHub
Skip to content

gpu info upon notebook import #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 27, 2024
Merged

gpu info upon notebook import #410

merged 5 commits into from
Feb 27, 2024

Conversation

kushalkolar
Copy link
Member

Displays gpu info when imported in notebooks

image

@kushalkolar kushalkolar requested a review from clewis7 February 24, 2024 07:25
clewis7
clewis7 reviewed Feb 24, 2024
View reviewed changes
Copy link
Member

@clewis7 clewis7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it locally on my mac and after removing the legends import statement seems to work fine. LGTM

@kushalkolar
Copy link
Member Author

I also need to add git lfs installs to the pypi publish action.

Should probably also wrap the print_gpu_info() call in __init__.py in a try except so that the info banner doesn't block import for any weird reason that doesn't affect fpl functionality.

@kushalkolar
Copy link
Member Author

glfw tests passing, I will checkout the notebook pixel ratio issue soon

@kushalkolar kushalkolar merged commit 7921516 into main Feb 27, 2024
@kushalkolar kushalkolar deleted the logos-gpu-info branch February 27, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clewis7 clewis7 clewis7 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kushalkolar @clewis7








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/fastplotlib/fastplotlib/pull/410

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy