Content-Length: 306040 | pFad | http://github.com/fastplotlib/fastplotlib/pull/820

86 Fix rect manager by kushalkolar · Pull Request #820 · fastplotlib/fastplotlib · GitHub
Skip to content

Fix rect manager #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 19, 2025
Merged

Fix rect manager #820

merged 5 commits into from
May 19, 2025

Conversation

kushalkolar
Copy link
Member

@kushalkolar kushalkolar commented May 15, 2025

#740 introduced bugs when imgui windows are added to the left or top edge of a figure. Got it working for grid layout. Need to get it working for the windowed layouts and setting from extents, add tests.

This was getting too complicated, for now just allow edgewindows to be added to the right or bottom edge.

This PR also adds a new example

funcs-2025-05-15_23.49.03.mp4

@kushalkolar kushalkolar marked this pull request as ready for review May 16, 2025 03:55
@kushalkolar kushalkolar requested a review from clewis7 as a code owner May 16, 2025 03:55
Copy link

📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/fix-rect-manager

@kushalkolar
Copy link
Member Author

kushalkolar commented May 16, 2025

@clewis7 ready for review

Copy link
Member

@clewis7 clewis7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clewis7 clewis7 merged commit 54deeaf into main May 19, 2025
28 of 52 checks passed
@clewis7 clewis7 deleted the fix-rect-manager branch May 19, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/fastplotlib/fastplotlib/pull/820

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy