Content-Length: 235614 | pFad | http://github.com/getsentry/sentry-javascript/issues/13700

7B UnhandledRejection errors should have `level:fatal` by default · Issue #13700 · getsentry/sentry-javascript · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnhandledRejection errors should have level:fatal by default #13700

Closed
romtsn opened this issue Sep 16, 2024 · 1 comment · Fixed by #15720
Closed

UnhandledRejection errors should have level:fatal by default #13700

romtsn opened this issue Sep 16, 2024 · 1 comment · Fixed by #15720
Assignees
@mydea
Labels
Package: node Issues related to the Sentry Node SDK

Comments

@romtsn
Copy link
Member

romtsn commented Sep 16, 2024 •
edited
Loading

Description

Because we terminate the process in the case of facing an unhandled promise rejection error, we should set its level to fatal (currently it defaults to error). Note that there are multiple modes, so we might wanna do this only when the mode is strict.
@romtsn romtsn added Package: core Issues related to the Sentry Core SDK Package: node Issues related to the Sentry Node SDK and removed Package: core Issues related to the Sentry Core SDK labels Sep 17, 2024
@AbhiPrasad AbhiPrasad added this to the 9.0.0 milestone Nov 1, 2024
@lforst lforst removed this from the 9.0.0 milestone Nov 13, 2024
@lforst lforst self-assigned this Mar 3, 2025
@mydea mydea assigned mydea and unassigned lforst Mar 18, 2025
@mydea mydea mentioned this issue Mar 18, 2025
Merged
@mydea mydea closed this as completed in aa1548f Mar 19, 2025
@github-actions GitHub Actions
Copy link
Contributor

A PR closing this issue has just been released 🚀

This issue was referenced by PR #15720, which was included in the 9.7.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mydea mydea

Labels
Package: node Issues related to the Sentry Node SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(node): Use fatal level for unhandled rejections in strict mode getsentry/sentry-javascript
4 participants
@mydea @romtsn @lforst @AbhiPrasad








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/getsentry/sentry-javascript/issues/13700

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy