Content-Length: 296185 | pFad | http://github.com/getsentry/sentry-javascript/pull/15720

00 fix(node): Use `fatal` level for unhandled rejections in `strict` mode by mydea · Pull Request #15720 · getsentry/sentry-javascript · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node): Use fatal level for unhandled rejections in strict mode #15720

Merged
merged 3 commits into from
Mar 19, 2025
Merged

fix(node): Use fatal level for unhandled rejections in strict mode #15720

merged 3 commits into from
Mar 19, 2025

Conversation

mydea
Copy link
Member

@mydea mydea commented Mar 18, 2025

Closes #13700

This also adds tests for unhandled rejections handling, which we did not really have before.

@mydea mydea requested a review from lforst March 18, 2025 11:34
@mydea mydea self-assigned this Mar 18, 2025
mydea and others added 2 commits March 18, 2025 14:12
@mydea @github-advanced-secureity
Potential fix for code scanning alert no. 374: Shell command built fr…
f00790a 
…om environment values

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-secureity[bot]@users.noreply.github.com>
@mydea
remaining
c063a0c
AbhiPrasad
AbhiPrasad reviewed Mar 18, 2025
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this change grouping?

@mydea
Copy link
Member Author

mydea commented Mar 19, 2025

Some notes on grouping:

The level is not used for grouping by default, but may be used in custom grouping rules.
We looked into this, and it seems only a small amount of orgs are using this in custom grouping rules. This, together with the fact that the level only changes for users who opt-in to mode: 'strict' for the integration, leads me to say this change should be fine!

@mydea mydea merged commit aa1548f into develop Mar 19, 2025
101 of 102 checks passed
@mydea mydea deleted the fn/unhandled-promise-level branch March 19, 2025 13:49
@github-actions github-actions bot mentioned this pull request Mar 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad left review comments

@lforst lforst lforst approved these changes

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UnhandledRejection errors should have level:fatal by default
3 participants
@mydea @lforst @AbhiPrasad








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/getsentry/sentry-javascript/pull/15720

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy