feat(browser): Add previous_trace span links
#15569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
Lms24
force-pushed
the
lms/feat-previous-trace-links
branch
from
66ec822 to
45bc790
Compare
s1gr1d
approved these changes
Mar 20, 2025
Comment on lines
396
to
400
| previousTraceInfo = addPreviousTraceSpanLink(previousTraceInfo, span); | ||
|
|
||
| if (persistPreviousTrace) { | ||
| storePreviousTraceInSessionStorage(previousTraceInfo); | ||
| } |
There was a problem hiding this comment.
I think all this code around the previous trace can be put in here. Then there is also no need to mutate the variable or store undefined in a variable if persisting is turned off.
Suggested change
| previousTraceInfo = addPreviousTraceSpanLink(previousTraceInfo, span); | |
| if (persistPreviousTrace) { | |
| storePreviousTraceInSessionStorage(previousTraceInfo); | |
| } | |
| if (persistPreviousTrace) { | |
| const updatedPreviousTraceInfo = addPreviousTraceSpanLink( | |
| getPreviousTraceFromSessionStorage(), span | |
| ) | |
| storePreviousTraceInSessionStorage(updatedPreviousTraceInfo); | |
| } |
There was a problem hiding this comment.
Happy to rewrite this but I still need to call addPreviousTraceSpanLink if persistPreviousTrace is false (as by default). Let me take another look
There was a problem hiding this comment.
I rewrote this a bit based on your suggestion as well as on unifying the two options. b44e790
Lms24
force-pushed
the
lms/feat-previous-trace-links
branch
from
0550ac6 to
6c42afd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logic to set the
previous_tracespan link on root spans (viabrowserTracingIntegration).Some notes:
linkPreviousTraceintegration option to control the trace linking behaviour:in-memory- default - previous trace data is linked and stored in memorysession-storage- previous trace data is linked and stored in session storageoff- no previous trace data is stored or linkedtracesSamplerbut this I'll tackle via Add possibility to sample subsequent traces based on previous trace sampling decision #15754browserTracingIntegration, meaning there's no bundle size hit for error-only users or users who only send manual spans (the latter is a tradeoff but I think it's a fair one)Happy to bike shed on the options naming :D
closes #14992
UPDATE: I rewrote the public API options from having two options (
enablePreviousTraceandpersistPreviousTrace) to only one which controls both aspects.