fix(nuxt): Add Nitro Rollup plugin to inject Sentry server config #15710
+50
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@s1gr1d Thanks for fixing! :) Is this part of the dynamic import method? To benefit from this, will we need to migrate from the --import method? |
|
No, it's not related :) The rollup plugin I added for this fix, only adds the server config to the build output (which was happening before already). The rollup plugin for the dynamic import is a different one and this was not changed: https://github.com/getsentry/sentry-javascript/blob/develop/packages/nuxt/src/vite/addServerConfig.ts#L204 |
s1gr1d
added a commit
that referenced
this pull request
Mar 18, 2025
Adding tests for the [nightly channel](https://nuxt.com/docs/guide/going-further/nightly-release-channel) of Nuxt. Right now, they are failing - will merge this PR once they are not failing anymore. See issue: #15628 This PR adds fixes to the tests should not fail anymore: #15710
3 tasks
|
thank you @s1gr1d ❤️ |
s1gr1d
added a commit
that referenced
this pull request
Mar 24, 2025
Due to PR #15710 the Sentry server config is only processed inside the Nitro-part of Nuxt and the server config file is emitted through the Rollup plugin. It is not needed anymore to copy-paste the file manually (this has been the case before as the file was added to the `.nuxt` folder - as it was processed by Nuxt, not Nitro-only). This fixes the "no such file" error [posted in this comment](#13330 (comment)). closes #13330
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the Sentry server config was added by adding another entry point in the rollup options of Vite. Since Nuxt changed
preserveModulestotrue, this did not work anymore. The aim of this change in Nuxt is to avoid duplicating what the Nitro build would do.This means, that we now don't change the Rollup options in Vite anymore (affects Nuxt as a whole) but only the Rollup options during the Nitro build.
The added plugin will emit a new file and returns the Sentry config code there.
fixes #15628