ref: Remove some usages of dropUndefinedKeys()
#15781
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
commented
Mar 21, 2025
| @@ -101,11 +100,11 @@ function _trackINP(): () => void { | |||
| const routeName = spanToUse ? spanToJSON(spanToUse).description : getCurrentScope().getScopeData().transactionName; | |||
|
|
|||
| const name = htmlTreeAsString(entry.target); | |||
| const attributes: SpanAttributes = dropUndefinedKeys({ | |||
| const attributes: SpanAttributes = { | |||
There was a problem hiding this comment.
nothing possibly undefined here!
mydea
commented
Mar 21, 2025
| @@ -36,7 +35,7 @@ export function createCheckInEnvelope( | |||
| } | |||
|
|
|||
| if (dynamicSamplingContext) { | |||
| headers.trace = dropUndefinedKeys(dynamicSamplingContext) as DynamicSamplingContext; | |||
| headers.trace = dynamicSamplingContext as DynamicSamplingContext; | |||
There was a problem hiding this comment.
this should not care if there is something undefined in there, I believe?
mydea
commented
Mar 21, 2025
| @@ -14,14 +13,14 @@ export function captureFeedback( | |||
|
|
|||
| const feedbackEvent: FeedbackEvent = { | |||
| contexts: { | |||
| feedback: dropUndefinedKeys({ | |||
| feedback: { | |||
There was a problem hiding this comment.
this should not care about undefined fields
mydea
commented
Mar 21, 2025
| @@ -137,7 +137,7 @@ export function closeSession(session: Session, status?: Exclude<SessionStatus, ' | |||
| * @returns a JSON object of the passed session | |||
| */ | |||
| function sessionToJSON(session: Session): SerializedSession { | |||
| return dropUndefinedKeys({ | |||
| return { | |||
There was a problem hiding this comment.
this is only called when we send the session, where this should be cleared out by JSON.stringify() anyhow
mydea
commented
Mar 21, 2025
| @@ -98,12 +98,12 @@ export function makeNetworkReplayBreadcrumb( | |||
| start: startTimestamp / 1000, | |||
| end: endTimestamp / 1000, | |||
| name: url, | |||
| data: dropUndefinedKeys({ | |||
| data: { | |||
There was a problem hiding this comment.
this should be fine to contain undefined
mydea
commented
Mar 21, 2025
| @@ -113,15 +113,15 @@ function _instrumentNavigations(client: Client): void { | |||
| routingSpan.end(); | |||
| } | |||
|
|
|||
| const navigationInfo = dropUndefinedKeys({ | |||
| const navigationInfo = { | |||
There was a problem hiding this comment.
attributes can be undefined, that should not change anything.
size-limit report 📦
|
AbhiPrasad
approved these changes
Mar 21, 2025
| @@ -36,7 +35,7 @@ export function createCheckInEnvelope( | |||
| } | |||
|
|
|||
| if (dynamicSamplingContext) { | |||
| headers.trace = dropUndefinedKeys(dynamicSamplingContext) as DynamicSamplingContext; | |||
| headers.trace = dynamicSamplingContext as DynamicSamplingContext; | |||
chargome
approved these changes
Mar 21, 2025
In some places this should not really be needed, so we can skip this.
mydea
force-pushed
the
fn/remove-more-dropUndefinedKeys
branch
from
c2c7934 to
13a0d88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some places this should not really be needed, so we can skip this.