feat(core): Add support for parameterizing logs #15812
Merged
+248
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
stephanie-anderson,
andreiborza,
Lms24 and
chargome
and removed request for
a team
7 tasks
chargome
approved these changes
Mar 25, 2025
| */ | ||
| export function parameterize(strings: TemplateStringsArray, ...values: string[]): ParameterizedString { | ||
| export function parameterize(strings: TemplateStringsArray, ...values: unknown[]): ParameterizedString { |
There was a problem hiding this comment.
Should we deprecate this then or do we just keep both?
There was a problem hiding this comment.
I'm gonna actually remove the fmt alias globally in favour of just leaving it in the logger namespace. We can revaluate this later.
There was a problem hiding this comment.
Actually nvm I thought about it again, and let's keep it because it makes the re-export super easy.
We can keep both, and evaluate deprecating parameterize at a later time.
s1gr1d
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #15526
This adds support for parameterizing logs via the existing
ParameterizedStringtype andparameterizefunction exported from the SDK. This works for all usages of the logger, so browser and Node.js.Usage:
fmtis an alias toSentry.parameterizethat is exported from theloggernamespace.To support this change, I changed the typing of
ParameterizedStringto acceptunknown[]for__sentry_template_values__. This is broadening the type, so should not be a breaking change.logentry.paramsshould accept all kinds of values, relay handles formatting them correctly.