Content-Length: 274733 | pFad | http://github.com/getsentry/sentry-javascript/pull/16678

0F fix(node): Ensure graphql errors result in errored spans by mydea · Pull Request #16678 · getsentry/sentry-javascript · GitHub
Skip to content

fix(node): Ensure graphql errors result in errored spans #16678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 23, 2025
Merged

fix(node): Ensure graphql errors result in errored spans #16678

merged 2 commits into from
Jun 23, 2025
+77 −1

Conversation

mydea
Copy link
Member

@mydea mydea commented Jun 23, 2025

Closes #16649

@mydea mydea requested review from AbhiPrasad and andreiborza June 23, 2025 08:32
@mydea mydea self-assigned this Jun 23, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 23, 2025 •
edited
Loading

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.99 kB - -
@sentry/browser - with treeshaking flags 23.76 kB - -
@sentry/browser (incl. Tracing) 38.8 kB - -
@sentry/browser (incl. Tracing, Replay) 76.94 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 70.02 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 81.7 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 93.78 kB - -
@sentry/browser (incl. Feedback) 40.74 kB - -
@sentry/browser (incl. sendFeedback) 28.7 kB - -
@sentry/browser (incl. FeedbackAsync) 33.59 kB - -
@sentry/react 25.76 kB - -
@sentry/react (incl. Tracing) 40.79 kB - -
@sentry/vue 28.36 kB - -
@sentry/vue (incl. Tracing) 40.67 kB - -
@sentry/svelte 24.01 kB - -
CDN Bundle 25.5 kB - -
CDN Bundle (incl. Tracing) 38.88 kB - -
CDN Bundle (incl. Tracing, Replay) 74.79 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 80.26 kB - -
CDN Bundle - uncompressed 74.5 kB - -
CDN Bundle (incl. Tracing) - uncompressed 115.33 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 229.38 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 242.21 kB - -
@sentry/nextjs (client) 42.43 kB - -
@sentry/sveltekit (client) 39.29 kB - -
@sentry/node 150.78 kB +0.02% +28 B 🔺
@sentry/node - without tracing 98.55 kB -0.01% -1 B 🔽
@sentry/aws-serverless 124.3 kB - -

View base workflow run

@mydea mydea merged commit d8f12c2 into develop Jun 23, 2025
319 of 320 checks passed
@mydea mydea deleted the fn/graphql-errors branch June 23, 2025 11:04
@github-actions github-actions bot mentioned this pull request Jun 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreiborza andreiborza andreiborza approved these changes

@AbhiPrasad AbhiPrasad Awaiting requested review from AbhiPrasad

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure errored node GraphQL requests result in spans with errored status
2 participants
@mydea @andreiborza








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/getsentry/sentry-javascript/pull/16678

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy