fix(cloudflare): Import types explicitly from worker-types #16704
+136
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oh nasty! What does |
AbhiPrasad
force-pushed
the
abhi-remove-default-cloudflare-types
branch
from
0b29316 to
d51db5c
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #16099
This PR removes
@cloudflare/worker-typesfrompackages/cloudflare/tsconfig.jsonin favour of explicitly importing it from the package. This is what cloudflare itself recommends: https://developers.cloudflare.com/workers/languages/typescript/This caused some type re-arranging. The workflow types from #16672 were also not in
@cloudflare/worker-typesso they had to be vendored in. I created cloudflare/workerd#4398 to report that.