Content-Length: 269337 | pFad | http://github.com/go-python/gpython/pull/241

A1 py: fix import on Windows by aisk · Pull Request #241 · go-python/gpython · GitHub
Skip to content

py: fix import on Windows #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2025
Merged

py: fix import on Windows #241

merged 1 commit into from
Jun 28, 2025
+3 −3

Conversation

aisk
Copy link
Contributor

@aisk aisk commented Jun 28, 2025

Currently gpython can't handle import on Windows because it's using path to handle file paths, which only support OSes which use / as path separator:

PS C:\Users\xxxxx\Source\gpython> go run . py\tests\string.py
Traceback (most recent call last):
  File "C:\\Users\\xxxxx\\Source\\gpython/py\\tests\\string.py", line 5, in <module>
FileNotFoundError: 'Failed to resolve "libtest"'
exit status 1

Using path/filepath can fix it.

@codecov Codecov
Copy link

codecov bot commented Jun 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.97%. Comparing base (79bb925) to head (db36b42).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #241   +/-   ##
=======================================
  Coverage   74.96%   74.97%           
=======================================
  Files          79       79           
  Lines       19107    19125   +18     
=======================================
+ Hits        14324    14339   +15     
- Misses       4105     4106    +1     
- Partials      678      680    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ncw
ncw approved these changes Jun 28, 2025
View reviewed changes
Copy link
Collaborator

@ncw ncw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thanks :-)

@ncw ncw merged commit 53b7b8e into go-python:main Jun 28, 2025
8 checks passed
@aisk aisk deleted the fix-windows-import branch June 28, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncw ncw ncw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aisk @ncw








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/go-python/gpython/pull/241

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy