Improve area floor picker UI and search #25540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bramkragten
reviewed
May 22, 2025
| @@ -232,7 +235,7 @@ export class HaPickerComboBox extends LitElement { | |||
| const searchString = ev.detail.value.trim() as string; | |||
|
|
|||
| const index = this._fuseIndex(this._items); | |||
| const fuse = new HaFuse(this._items, {}, index); | |||
| const fuse = new HaFuse(this._items, { shouldSort: false }, index); | |||
There was a problem hiding this comment.
I think this was the intention?
Suggested change
| const fuse = new HaFuse(this._items, { shouldSort: false }, index); | |
| const fuse = new HaFuse(this._items, { shouldSort: !this.noResultSorting }, index); |
bramkragten
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Improve area floor picker UI and search
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: