Content-Length: 289127 | pFad | http://github.com/interactions-py/interactions.py/pull/1649

DD fix: Fix import errors introduced in CronTrigger feature by silasary · Pull Request #1649 · interactions-py/interactions.py · GitHub
Skip to content

fix: Fix import errors introduced in CronTrigger feature #1649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2024
Merged

fix: Fix import errors introduced in CronTrigger feature #1649

merged 1 commit into from
Apr 3, 2024

Conversation

silasary
Copy link
Member

Pull Request Type

  • Feature addition
  • Bugfix
  • Documentation update
  • Code refactor
  • Tests improvement
  • CI/CD pipeline enhancement
  • Other: [Replace with a description]

Description

#1632 was merged in a broken state. This PR makes it so you can successfully import the library again.

Changes

  • Moved fake import to TYPE_CHECKING.
  • Added new dependency to requirements.txt

Test Scenarios

Run pytest before and after this PR.

Python Compatibility

  • I've ensured my code works on Python 3.10.x
  • I've ensured my code works on Python 3.11.x

Checklist

  • I've run the pre-commit code linter over all edited files
  • I've tested my changes on supported Python versions
  • I've added tests for my code, if applicable
  • I've updated / added documentation, where applicable

@silasary
fix: Add croniter to requirements.txt, and change the import of the s…
950675c 
…tub-only `datetime._TzInfo` to only run when type checking
@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 52.91667% with 113 lines in your changes are missing coverage. Please review.

Project coverage is 46.12%. Comparing base (0129d53) to head (950675c).
Report is 23 commits behind head on stable.

Files Patch % Lines
interactions/client/client.py 28.57% 15 Missing ⚠️
interactions/models/discord/timestamp.py 23.07% 10 Missing ⚠️
...eractions/api/events/processors/reaction_events.py 18.18% 9 Missing ⚠️
interactions/models/internal/context.py 46.15% 7 Missing ⚠️
interactions/client/smart_cache.py 14.28% 6 Missing ⚠️
interactions/ext/paginators.py 0.00% 6 Missing ⚠️
...nteractions/api/http/http_requests/entitlements.py 66.66% 5 Missing ⚠️
interactions/models/discord/user.py 28.57% 5 Missing ⚠️
interactions/models/internal/tasks/triggers.py 54.54% 5 Missing ⚠️
interactions/api/http/http_client.py 0.00% 4 Missing ⚠️
... and 18 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           stable    #1649      +/-   ##
==========================================
+ Coverage   45.96%   46.12%   +0.15%     
==========================================
  Files         144      147       +3     
  Lines       15437    15650     +213     
==========================================
+ Hits         7096     7218     +122     
- Misses       8341     8432      +91

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@silasary silasary changed the base branch from stable to unstable March 31, 2024 13:22
@silasary silasary mentioned this pull request Mar 31, 2024
Open
13 tasks
@silasary silasary requested a review from zevaryx April 1, 2024 07:06
eightween
eightween approved these changes Apr 1, 2024
View reviewed changes
Copy link
Member

@eightween eightween left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

push rights to zev/sila, approving as usual

@silasary silasary merged commit b96eece into unstable Apr 3, 2024
@silasary silasary deleted the cron-fix branch April 3, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eightween eightween eightween approved these changes

@zevaryx zevaryx Awaiting requested review from zevaryx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@silasary @codecov-commenter @eightween








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/interactions-py/interactions.py/pull/1649

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy