fix(lit-html,lit,lit-element): adjust ssr directive patch condition #4988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve needs to be patched by comparing Function.name
🦋 Changeset detectedLatest commit: 8ef20f6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
augustjk
approved these changes
May 16, 2025
Co-authored-by: Augustine Kim <augustjkim@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adjusted the comparison to use the Function.name property of the
_$resolvefunction and theresolveOverrideFnin private ssr support to prevent attempted duplicative patching of a directive class.It appears that after the first patching the directive, like
classMap, that the conditional check remainsfalse. The member/method on the class is still_$resolve, but its name isssrResolve. Further processing of checking the Prototype of the directive withproto.hasOwnProperty(resolveMethodName)sincessrResolvedoesn't exist. That path leads to an error being thrown and breaks SSR for that render.Hopefully addresses Issue #4527