Content-Length: 244284 | pFad | http://github.com/llvm/clangir/pull/1492

93 [CIR][CUDA] Lower __syncthreads by AdUhTkJm · Pull Request #1492 · llvm/clangir · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CIR][CUDA] Lower __syncthreads #1492

Closed
wants to merge 1 commit into from
Closed

[CIR][CUDA] Lower __syncthreads #1492

wants to merge 1 commit into from

Conversation

AdUhTkJm
Copy link
Contributor

@AdUhTkJm AdUhTkJm commented Mar 17, 2025 •
edited
Loading

I have no idea how that's done in OG: the whole clang/lib folder doesn't refer to NVPTX::BI__syncthreads anywhere. Here in CIR we just add a switch case on it.

By the way, on the default case it should return a null pointer rather than NYI. It will be handled gracefully in emitBuiltinExpr as an error message will be emitted there.

@bcardosolopes
Copy link
Member

I have no idea how that's done in OG: the whole clang/lib folder doesn't refer to NVPTX::BI__syncthreads anywhere.

I see it in clang/include/clang/Basic/BuiltinsNVPTX.def, but I cannot find it in any .inc file because my build targets don't include NVPTX (try grep'ing your build dir). Very likely there's some tablegen game going on, we should do the same to make life easier when adding other NVPTX intrinsics that do the same!

@AdUhTkJm
Copy link
Contributor Author

I'll close this one as I solved it in a more general way.

@AdUhTkJm AdUhTkJm closed this Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lanza lanza

@bcardosolopes bcardosolopes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdUhTkJm @bcardosolopes








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/llvm/clangir/pull/1492

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy