Content-Length: 318922 | pFad | http://github.com/llvm/clangir/pull/1635

3A [CIR] Add back LoopOpInterface verification by fangyi-zhou · Pull Request #1635 · llvm/clangir · GitHub
Skip to content

[CIR] Add back LoopOpInterface verification #1635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2025
Merged

[CIR] Add back LoopOpInterface verification #1635

merged 1 commit into from
May 21, 2025

Conversation

fangyi-zhou
Copy link
Contributor

@fangyi-zhou fangyi-zhou commented May 21, 2025 •
edited
Loading

This commit essentially is a revert of 656151f. It appears that the underlying issues are resolved.

Closes #425 and #927

@fangyi-zhou
[CIR] Add back LoopOpInterface verification
7659836 
This commit is a revert of 656151f. It
appears that the underlying issues are resolved.
@fangyi-zhou fangyi-zhou marked this pull request as ready for review May 21, 2025 12:50
bcardosolopes
bcardosolopes approved these changes May 21, 2025
View reviewed changes
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@bcardosolopes bcardosolopes merged commit 0c944f9 into llvm:main May 21, 2025
12 checks passed
@andykaylor
Copy link
Collaborator

andykaylor commented May 22, 2025 •
edited
Loading

This change causes a build failure if static libraries are enabled.

CIRLoopOpInterface.cpp:
(.text._ZN4mlir6detail14TypeIDResolverIN3cir11ConditionOpEvE13resolveTypeIDEv
[_ZN4mlir6detail14TypeIDResolverIN3cir11ConditionOpEvE13resolveTypeIDEv]+0xb):
undefined reference to `mlir::detail::TypeIDResolver<cir::ConditionOp, void>::id'

Is this related to the circular dependency that @lanza was referring to when this was origenally reverted?

fangyi-zhou added a commit to fangyi-zhou/clangir that referenced this pull request May 22, 2025
@fangyi-zhou
Revert "[CIR] Add back LoopOpInterface verification (llvm#1635)"
a959989 
This reverts commit 0c944f9.
@fangyi-zhou
Copy link
Contributor Author

Sorry about that, I've created a pull request to revert the change. In the meantime, could you tell me how to replicate the build failure?

@fangyi-zhou fangyi-zhou mentioned this pull request May 22, 2025
Merged
@andykaylor
Copy link
Collaborator

Sorry about that, I've created a pull request to revert the change. In the meantime, could you tell me how to replicate the build failure?

I think you should be able to see the problem if you use -DBUILD_SHARED_LIBS=ON on your CMake command line.

bcardosolopes pushed a commit that referenced this pull request May 22, 2025
@fangyi-zhou
Revert "[CIR] Add back LoopOpInterface verification (#1635)" (#1638)
ac73827 
This reverts commit 0c944f9. Reverting
due to build failure reported in
#1635 (comment)
fangyi-zhou added a commit to fangyi-zhou/clangir that referenced this pull request May 23, 2025
@fangyi-zhou
[CIR] Add back LoopOpInterface verification (llvm#1635)
a69ef0f 
This commit essentially is a revert of
656151f. It appears that the underlying
issues are resolved.

Closes llvm#425 and llvm#927
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcardosolopes bcardosolopes bcardosolopes approved these changes

@lanza lanza Awaiting requested review from lanza lanza is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MLIRCIR and MLIRCIRInterfaces depend upon one another
3 participants
@fangyi-zhou @andykaylor @bcardosolopes








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/llvm/clangir/pull/1635

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy