Content-Length: 588957 | pFad | http://github.com/lowcoder-org/lowcoder/pull/1817/files

44 Search in Publish Permission Dialog by kamalqureshi · Pull Request #1817 · lowcoder-org/lowcoder · GitHub
Skip to content

Search in Publish Permission Dialog #1817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions client/packages/lowcoder/src/api/applicationApi.ts
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ class ApplicationApi extends Api {
static publicToMarketplaceURL = (applicationId: string) => `/applications/${applicationId}/public-to-marketplace`;
static getMarketplaceAppURL = (applicationId: string) => `/applications/${applicationId}/view_marketplace`;
static setAppEditingStateURL = (applicationId: string) => `/applications/editState/${applicationId}`;
static getAvailableGroupsMembersURL = (applicationId: string) => `/applications/${applicationId}/groups-members/available`;
static serverSettingsURL = () => `/serverSettings`;

static fetchHomeData(request: HomeDataPayload): AxiosPromise<HomeDataResponse> {
Expand Down Expand Up @@ -217,6 +218,10 @@ class ApplicationApi extends Api {
});
}

static getAvailableGroupsMembers(applicationId: string, search: string): AxiosPromise<any> {
return Api.get(ApplicationApi.getAvailableGroupsMembersURL(applicationId), {search})
}

/**
* set app as public
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,15 @@ import {
CloseIcon,
CommonTextLabel,
CustomSelect,
Search,
TacoButton,
} from "lowcoder-design";
import { useEffect, useRef, useState } from "react";
import { useEffect, useRef, useState, useCallback } from "react";
import styled from "styled-components";
import { debounce } from "lodash";
import ProfileImage from "pages/common/profileImage";
import { useDispatch, useSelector } from "react-redux";
import { fetchGroupsAction, fetchOrgUsersAction } from "redux/reduxActions/orgActions";
import { getOrgGroups, getOrgUsers } from "redux/selectors/orgSelectors";
import { OrgGroup, OrgUser } from "constants/orgConstants";
import { ApplicationPermissionType, ApplicationRoleType } from "constants/applicationConstants";
import { useSelector } from "react-redux";
import { ApplicationPermissionType, ApplicationRoleType, GroupsMembersPermission } from "constants/applicationConstants";
import {
PermissionItemName,
RoleSelectOption,
Expand All @@ -27,6 +26,8 @@ import { getUser } from "redux/selectors/usersSelectors";
import { EmptyContent } from "pages/common/styledComponent";
import { trans } from "i18n";
import { PermissionItem } from "./PermissionList";
import { currentApplication } from "@lowcoder-ee/redux/selectors/applicationSelector";
import { fetchAvailableGroupsMembers } from "@lowcoder-ee/util/pagination/axios";

const AddAppUserContent = styled.div`
display: flex;
Expand Down Expand Up @@ -86,20 +87,19 @@ const PermissionSelectWrapper = styled.div`
padding: 4px 8px;
margin-top: 8px;
background: #fdfdfd;
outline: 1px solid #d7d9e0;
border-radius: 4px;
outline: 1px dashed #d7d9e0;

.ant-select {
font-size: 13px;
line-height: 13px;
}

&:hover {
outline: 1px solid #8b8fa3;
outline: 1px dashed #8b8fa3;
}

&:focus-within {
outline: 1px solid #315efb;
outline: 1px dashed rgb(203, 212, 245);
border-radius: 4px;
box-shadow: 0 0 0 3px rgb(24 144 255 / 20%);
}
Expand Down Expand Up @@ -199,48 +199,34 @@ type PermissionAddEntity = {
key: string;
};

/**
* compose users and groups's permissions, filter the data
*
* @param orgGroups groups
* @param orgUsers users
* @param currentUser currentUser
* @param filterItems filterItems
*/
function isGroup(data: GroupsMembersPermission) {
return data?.type === "Group"
}

function getPermissionOptionView(
orgGroups: OrgGroup[],
orgUsers: OrgUser[],
currentUser: User,
groupsMembers: GroupsMembersPermission[],
filterItems: PermissionItem[]
): AddAppOptionView[] {
let permissionViews: AddAppOptionView[] = orgGroups.map((group) => {

let permissionsViews = groupsMembers?.map((user) => {
return {
type: "GROUP",
id: group.groupId,
name: group.groupName,
};
});
permissionViews = permissionViews.concat(
orgUsers.map((user) => {
return {
type: "USER",
id: user.userId,
name: user.name,
avatarUrl: user.avatarUrl,
};
})
);
permissionViews = permissionViews.filter(
(v) =>
!filterItems.find((i) => i.id === v.id && i.type === v.type) &&
!(v.type === "USER" && v.id === currentUser.id)
type: user.type as ApplicationPermissionType,
id: isGroup(user) ? user.data.groupId : user.data.userId,
name: isGroup(user) ? user.data.groupName : user.data.name,
...(isGroup(user) ? {} : { avatarUrl: user.data.avatarUrl })
}
})

permissionsViews = permissionsViews.filter((v) =>
!filterItems.find((i) => i.id === v.id && i.type === v.type)
);
return permissionViews;

return permissionsViews.filter((v) => v.id && v.name) as AddAppOptionView[];
}

function PermissionSelectorOption(props: { optionView: AddAppOptionView }) {
const { optionView } = props;
const groupIcon = optionView.type === "GROUP" && (
const groupIcon = optionView.type === "Group" && (
<StyledGroupIcon $color={getInitialsAndColorCode(optionView.name)[1]} />
);
return (
Expand All @@ -258,7 +244,7 @@ function PermissionSelectorOption(props: { optionView: AddAppOptionView }) {

function PermissionSelectorLabel(props: { view: AddAppOptionView }) {
const { view } = props;
const groupIcon = view.type === "GROUP" && (
const groupIcon = view.type === "Group" && (
<StyledGroupIcon $color={getInitialsAndColorCode(view.name)[1]} $side={9} />
);
return (
Expand Down Expand Up @@ -309,12 +295,52 @@ const PermissionSelector = (props: {
filterItems: PermissionItem[];
supportRoles: { label: string; value: PermissionRole }[];
}) => {
const orgGroups = useSelector(getOrgGroups);
const orgUsers = useSelector(getOrgUsers);
const { selectedItems, setSelectRole, setSelectedItems, user } = props;
const optionViews = getPermissionOptionView(orgGroups, orgUsers, user, props.filterItems);
const [roleSelectVisible, setRoleSelectVisible] = useState(false);
const selectRef = useRef<HTMLDivElement>(null);
const [optionViews, setOptionViews] = useState<AddAppOptionView[]>()
const [searchValue, setSearchValue] = useState("");
const [isLoading, setIsLoading] = useState(false);
const application = useSelector(currentApplication)

const debouncedUserSearch = useCallback(
debounce((searchTerm: string) => {
if (!application) return;

setIsLoading(true);
fetchAvailableGroupsMembers(application.applicationId, searchTerm).then(res => {
if(res.success) {
setOptionViews(getPermissionOptionView(res.data, props.filterItems))
}
setIsLoading(false);
}).catch(() => {
setIsLoading(false);
});
}, 500),
[application, props.filterItems]
);

useEffect(() => {
debouncedUserSearch(searchValue);

return () => {
debouncedUserSearch.cancel();
};
}, [searchValue, debouncedUserSearch]);

useEffect(() => {
if (!application) return;

setIsLoading(true);
fetchAvailableGroupsMembers(application.applicationId, "").then(res => {
if(res.success) {
setOptionViews(getPermissionOptionView(res.data, props.filterItems))
}
setIsLoading(false);
}).catch(() => {
setIsLoading(false);
});
}, [application, props.filterItems]);

useEffect(() => {
setRoleSelectVisible(selectedItems.length > 0);
Expand All @@ -325,12 +351,18 @@ const PermissionSelector = (props: {

return (
<>
<Search
placeholder={trans("home.addPermissionPlaceholder")}
value={searchValue}
onChange={(e) => setSearchValue(e.target.value)}
/>
<PermissionSelectWrapper>
<AddPermissionsSelect
open
ref={selectRef}
placeholder={trans("home.addPermissionPlaceholder")}
placeholder={trans("home.selectedUsersAndGroups")}
mode="multiple"
showSearch={false}
getPopupContainer={() => document.getElementById("add-app-user-permission-dropdown")!}
optionLabelProp="label"
tagRender={PermissionTagRender}
Expand All @@ -350,7 +382,7 @@ const PermissionSelector = (props: {
setSelectedItems(selectedItems.filter((item) => item.key !== option.key));
}}
>
{optionViews.map((view) => {
{optionViews?.map((view) => {
return (
<CustomSelect.Option
key={`${view.type}-${view.id}`}
Expand Down Expand Up @@ -395,16 +427,10 @@ export const Permission = (props: {
addPermission: (userIds: string[], groupIds: string[], role: string) => void;
}) => {
const { onCancel } = props;
const dispatch = useDispatch();
const user = useSelector(getUser);
const [selectRole, setSelectRole] = useState<ApplicationRoleType>("viewer");
const [selectedItems, setSelectedItems] = useState<PermissionAddEntity[]>([]);

useEffect(() => {
dispatch(fetchOrgUsersAction(user.currentOrgId));
dispatch(fetchGroupsAction(user.currentOrgId));
}, []);

return (
<AddAppUserContent>
<CommonTextLabel style={{ marginTop: "16px" }}>
Expand All @@ -426,10 +452,10 @@ export const Permission = (props: {
buttonType="primary"
onClick={() => {
const uids = selectedItems
.filter((item) => item.type === "USER")
.filter((item) => item.type === "User")
.map((item) => item.id);
const gids = selectedItems
.filter((item) => item.type === "GROUP")
.filter((item) => item.type === "Group")
.map((item) => item.id);
if (uids.length === 0 && gids.length === 0) {
onCancel();
Expand Down
14 changes: 13 additions & 1 deletion client/packages/lowcoder/src/constants/applicationConstants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,14 +62,26 @@ export const AppUILayoutType: Record<AppTypeEnum, UiLayoutType> = {

export type ApplicationDSLType = "editing" | "published" | "view_marketplace";
export type ApplicationRoleType = "viewer" | "editor" | "owner";
export type ApplicationPermissionType = "USER" | "GROUP" | "ORG_ADMIN";
export type ApplicationPermissionType = "User" | "Group" | "ORG_ADMIN" | "USER" | "GROUP";

export interface ApplicationExtra {
moduleHeight?: number;
moduleWidth?: number;
layers?: boolean;
}

export type GroupsMembersPermission = {
type: string
data: {
groupGid?: string
groupId?: string
userId?: string
groupName?: string
name?: string
avatarUrl?: string
}
}

export interface ApplicationMeta {
name: string;
applicationType: AppTypeEnum;
Expand Down
1 change: 1 addition & 0 deletions client/packages/lowcoder/src/i18n/locales/en.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4010,6 +4010,7 @@ export const en = {
"orgName": "{orgName} admins",
"addMember": "Add members",
"addPermissionPlaceholder": "Please enter a name to search members",
"selectedUsersAndGroups":"Selected Users and Groups",
"searchMemberOrGroup": "Search for members or groups: ",
"addPermissionErrorMessage": "Failed to add permission, {message}",
"copyModalTitle": 'Clone "{name}"',
Expand Down
16 changes: 16 additions & 0 deletions client/packages/lowcoder/src/util/pagination/axios.ts
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,22 @@ export const fetchGroupUsrPagination = async (request: fetchGroupUserRequestType
}
}

export const fetchAvailableGroupsMembers = async (applicationId: string, search: string) => {
try{
const response = await ApplicationApi.getAvailableGroupsMembers(applicationId, search)
return {
success: true,
data: response.data.data
}
} catch (error: any) {
console.error('Failed to fetch data: ', error)
return {
success: false,
error: error
}
}
}

export const fetchOrgUsrPagination = async (request: fetchOrgUserRequestType)=> {
try {
const response = await OrgApi.fetchOrgUsersPagination(request);
Expand Down
Loading








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/lowcoder-org/lowcoder/pull/1817/files

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy