#3072 Fixes proper ignoring of "removers" that often is accompanying … #3082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarlesat
force-pushed
the
bugfix/3072
branch
from
683b5bc to
ed6c400
Compare
|
Should this branch be rebased on main, as main now is version 1.7-SNAPSHOT? Anything else that should be done with it? |
|
Sorry I have not reviewed this. @jarlesat it would indeed be good to rebase it on top of main. Additionally, if you can move the test in |
|
Please let me know if there are anything more that should be done, test cases or anything. Maybe branch-name? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore unmapped "removers" in target classes. Fluent removers are generated by tools like OpenAPI generator, preventing the use of
unmappedTargetPolicy=ERRORunless adding@Mapping(target='removeItem', ignore=true)for every single remover.Fixes #3072