#3617 support for target this enum mapping. #3616
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| /* | ||
| * Copyright MapStruct Authors. | ||
| * | ||
| * Licensed under the Apache License version 2.0, available at http://www.apache.org/licenses/LICENSE-2.0 | ||
| */ | ||
| package org.mapstruct.ap.internal.model.assignment; | ||
|
|
||
| import org.mapstruct.ap.internal.model.common.Assignment; | ||
|
|
||
| /** | ||
| * Decorates an assignment as a return variable. | ||
| * | ||
| * @author Ben Zegveld | ||
| */ | ||
| public class ResultWrapper extends AssignmentWrapper { | ||
|
|
||
| public ResultWrapper(Assignment decoratedAssignment) { | ||
| super( decoratedAssignment, false ); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| <#-- | ||
|
|
||
| Copyright MapStruct Authors. | ||
|
|
||
| Licensed under the Apache License version 2.0, available at http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| --> | ||
| <#-- @ftlvariable name="" type="org.mapstruct.ap.internal.model.assignment.ReturnWrapper" --> | ||
| ${ext.targetBeanName} = <@_assignment/>; | ||
| <#macro _assignment> | ||
| <@includeModel object=assignment | ||
| targetBeanName=ext.targetBeanName | ||
| existingInstanceMapping=ext.existingInstanceMapping | ||
| targetReadAccessorName=ext.targetReadAccessorName | ||
| targetWriteAccessorName=ext.targetWriteAccessorName | ||
| targetPropertyName=ext.targetPropertyName | ||
| targetType=ext.targetType/> | ||
| </#macro> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| /* | ||
| * Copyright MapStruct Authors. | ||
| * | ||
| * Licensed under the Apache License version 2.0, available at http://www.apache.org/licenses/LICENSE-2.0 | ||
| */ | ||
| package org.mapstruct.ap.test.bugs._2421; | ||
|
|
||
| import org.mapstruct.Mapper; | ||
| import org.mapstruct.Mapping; | ||
| import org.mapstruct.MappingConstants; | ||
| import org.mapstruct.ValueMapping; | ||
|
|
||
| @Mapper | ||
| abstract class Issue2421Mapper { | ||
|
|
||
| @Mapping( target = ".", source = "value" ) | ||
| @ValueMapping( target = "C", source = MappingConstants.ANY_REMAINING ) | ||
| public abstract EnumExample dtoTestToEnum(InnerDtoTest innerDtoTest); | ||
|
|
||
| } | ||
|
|
||
| enum EnumExample { | ||
| A, B, C | ||
| } | ||
|
|
||
| class InnerDtoTest { | ||
| private String value; | ||
|
|
||
| public String getValue() { | ||
| return value; | ||
| } | ||
|
|
||
| public void setValue(String value) { | ||
| this.value = value; | ||
| } | ||
| } | ||
|
|
||
| class TargetTest { | ||
| private EnumExample enumExampleValue; | ||
|
|
||
| public EnumExample getEnumExampleValue() { | ||
| return enumExampleValue; | ||
| } | ||
|
|
||
| public void setEnumExampleValue(EnumExample enumExampleValue) { | ||
| this.enumExampleValue = enumExampleValue; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| /* | ||
| * Copyright MapStruct Authors. | ||
| * | ||
| * Licensed under the Apache License version 2.0, available at http://www.apache.org/licenses/LICENSE-2.0 | ||
| */ | ||
| package org.mapstruct.ap.test.bugs._2421; | ||
|
|
||
| import org.mapstruct.ap.testutil.ProcessorTest; | ||
| import org.mapstruct.ap.testutil.WithClasses; | ||
|
|
||
| public class Issue2421Test { | ||
|
There was a problem hiding this comment. Sorry, we would need to change the issue number to 3617 - might aswell add @IssueKey("3617") here. |
||
|
|
||
| @ProcessorTest | ||
| @WithClasses( Issue2421Mapper.class ) | ||
| void shouldCompile() { | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to have no effect in this case, however this seems fishy - maybe just not set
sourcePropertyNameat all?