fix: Ensure NullValuePropertyMappingStrategy.SET_TO_DEFAULT initializes empty collection/map when target is null #3871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es empty collection/map when target is null Signed-off-by: TangYang <tangyang9464@163.com>
|
@filiphr There was a fixture test about I think the bug may be related to this comment，but to be honest, I don’t quite understand what this sentence means. It's correct for SET_TO_NULL and IGNORE, and the else branch should not be generated. But it doesn't apply to SET_TO_DEFAULT
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #3865
When both source and target Map/List properties are null and
nullValuePropertyMappingStrategy is SET_TO_DEFAULT, the target property should be set to an empty collection instead of remaining null.This commit adds the necessary else branch to
ExistingInstanceSetterWrapperForCollectionsAndMaps.ftlto handle this case correctly.