Content-Length: 237333 | pFad | http://github.com/mastodon/mastodon/pull/33485

B0 Reduce overridden values in `haml-lint` configuration by mjankowski · Pull Request #33485 · mastodon/mastodon · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce overridden values in haml-lint configuration #33485

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mjankowski
Copy link
Contributor

For both LineLength and ViewLength we are overriding the default values haml-lint uses. Change here bumps them down to 2^7 and 2^8, respectively.

For line length - there was one remaining violation which was new since last rebase of this branch, which is corrected here (can pull out earlier if desired). I think this line length value should go even further, but did not want to put any views in a state where some lines are JUST UNDER the limit and normal/unrelated changes trigger this. There are only 3 views with lines over 235, so hopefully there's some buffer and we avoid that. Will do more future passes on this to further reduce ... something like ~160 (2x the default) seems like a reasonable long term target for this.

For view length - there are only 2 views over 100, both of which (in my opinion) could/should reduce further - so we can probably get to the default on this one eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/mastodon/mastodon/pull/33485

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy