Reduce overridden values in haml-lint
configuration
#33485
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For both
LineLength
andViewLength
we are overriding the default valueshaml-lint
uses. Change here bumps them down to 2^7 and 2^8, respectively.For line length - there was one remaining violation which was new since last rebase of this branch, which is corrected here (can pull out earlier if desired). I think this line length value should go even further, but did not want to put any views in a state where some lines are JUST UNDER the limit and normal/unrelated changes trigger this. There are only 3 views with lines over 235, so hopefully there's some buffer and we avoid that. Will do more future passes on this to further reduce ... something like ~160 (2x the default) seems like a reasonable long term target for this.
For view length - there are only 2 views over 100, both of which (in my opinion) could/should reduce further - so we can probably get to the default on this one eventually.