Fix parsing complex numbers like -1+1j #17383
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Epler <jepler@gmail.com>
jepler
force-pushed
the
complex-sign-error
branch
from
ad011fd to
2388d64
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #17383 +/- ##
=======================================
Coverage 98.54% 98.54%
=======================================
Files 169 169
Lines 21898 21898
=======================================
Hits 21579 21579
Misses 319 319 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jepler
force-pushed
the
complex-sign-error
branch
from
2388d64 to
93245bf
Compare
|
Code size report: |
If a complex literal had a negative real part and a positive complex part, it was not parsed properly. Co-Authored-By: ComplexSymbol <141301057+ComplexSymbol@users.noreply.github.com> Signed-off-by: Jeff Epler <jepler@gmail.com>
jepler
force-pushed
the
complex-sign-error
branch
from
93245bf to
8b1232d
Compare
dpgeorge
approved these changes
Jun 10, 2025
|
Rebased, squashed and merged in 2ce63b1 Thanks for the neat fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Over in adafruit#10297 a contributor noticed a bug and offered a fix for parsing of complex numbers like
complex("-1+1j"). The fix looked minimal and based on testing seems correct, so I decided to offer it over here.Testing
I added a pair of initially failing tests to the test suite, and then checked that the fix made them pass.
Trade-offs and Alternatives
I also noticed that the non-standard complex literal
complex("1 1j")is accepted by micropython but not python3. It is accepted as an argument to the built incomplexfunction but not as a literal in source code. A more complete fix might make this into an error too.