Content-Length: 361849 | pFad | http://github.com/nautobot/nautobot/pull/6672

0A Requesting media files requires authentication by timizuoebideri1 · Pull Request #6672 · nautobot/nautobot · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Requesting media files requires authentication #6672

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Requesting media files requires authentication #6672

wants to merge 9 commits into from

Conversation

timizuoebideri1
Copy link
Contributor

Closes #DNE

What's Changed

Screenshots

TODO

  • Explanation of Change(s)
  • Added change log fragment(s) (for more information see the documentation)
  • Attached Screenshots, Payload Example
  • Unit, Integration Tests
  • Documentation Updates (when adding/changing features)
  • Example App Updates (when adding/changing features)
  • Outline Remaining Work, Constraints from Design

glennmatthews
glennmatthews reviewed Dec 17, 2024
View reviewed changes
Copy link
Contributor

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please target to develop rather than next
  2. Seems like there probably should be some update to nautobot.core.tests.integration.test_view_authentication corresponding to this change - there must be a gap in the current test given that this change didn't make any part of it fail?

nautobot/core/tests/test_views.py Outdated Show resolved Hide resolved
nautobot/core/tests/test_views.py Outdated Show resolved Hide resolved
@timizuoebideri1 timizuoebideri1 changed the base branch from next to develop December 17, 2024 22:24
@timizuoebideri1 timizuoebideri1 changed the base branch from develop to next December 17, 2024 22:25
@timizuoebideri1 timizuoebideri1 force-pushed the u/timizuoebideri1-media_auth-required branch from 312fb29 to efa1867 Compare December 17, 2024 22:38
@timizuoebideri1 timizuoebideri1 force-pushed the u/timizuoebideri1-media_auth-required branch from efa1867 to b3ccefd Compare December 17, 2024 22:45
@timizuoebideri1 timizuoebideri1 changed the base branch from next to develop December 17, 2024 22:46
@HanlinMiao HanlinMiao mentioned this pull request Dec 18, 2024
Merged
7 tasks
glennmatthews
glennmatthews requested changes Dec 18, 2024
View reviewed changes
nautobot/core/views/__init__.py Outdated Show resolved Hide resolved
@timizuoebideri1 timizuoebideri1 force-pushed the u/timizuoebideri1-media_auth-required branch from e9b5b2c to b663135 Compare December 19, 2024 08:26
@glennmatthews glennmatthews changed the title Requesting static media requires authentication Requesting media files requires authentication Dec 30, 2024
@glennmatthews glennmatthews mentioned this pull request Dec 30, 2024
Open
bryanculver
bryanculver reviewed Dec 31, 2024
View reviewed changes
Copy link
Member

@bryanculver bryanculver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with these changes as-is and shouldn't break anything for S3-backed assets as well but I am still verifying if it will be an incomplete fix in those cases (confirming if assets are served from s3 directly or if they all go through this view).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryanculver bryanculver bryanculver left review comments

@glennmatthews glennmatthews glennmatthews approved these changes

Assignees

@timizuoebideri1 timizuoebideri1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timizuoebideri1 @bryanculver @glennmatthews








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/nautobot/nautobot/pull/6672

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy