INTERNAL: Modify the term related to eflag #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
rebase 되었습니다. |
jhpark816
reviewed
Dec 26, 2024
| - \<foperand\>는 bitwise 연산을 취할 operand로 hexadecimal로 표현한다. | ||
| \<foperand\>의 길이는 compare 연산을 취한 \<fvalue\>의 길이와 동일하여야 한다. | ||
| - \<compop\> \<fvalue\> | ||
| - \<bitwvalue\>는 bitwise 연산을 취할 operand로 hexadecimal로 표현한다. |
There was a problem hiding this comment.
단순 변경만 하고, 문장을 읽어보지 않았네요.
문장을 읽어보면서 수정할 사항이 있는 지도 확인해 주세요.
ing-eoking
force-pushed
the
update
branch
3 times, most recently
from
c86074e to
7e988dc
Compare
jhpark816
reviewed
Dec 26, 2024
| @@ -102,28 +102,28 @@ bkey의 hexadecimal 표현과 저장 방식을 그대로 따른다. | |||
|
|
|||
| eflag에 대한 filter 조건은 아래와 같이 표현하며, | |||
| (1) eflag의 전체/부분 값과 특정 값과의 compare 연산이나 | |||
| (2) eflag의 전체/부분 값에 대해 어떤 operand로 bitwise 연산을 취한 후의 결과와 특정 값과의 compare 연산이다. | |||
| (2) eflag의 전체/부분 값에 대해 주어진 값과 bitwise 연산을 취한 결과와 특정 값과의 compare 연산이다. | |||
There was a problem hiding this comment.
"주어진 값과" 부분이 없어도 문장이 충분히 이해되니, 제거하시죠.
t/coll_bop_eflag.t
Outdated
| @@ -42,13 +42,13 @@ sub do_btree_efilter { | |||
| $bkrange = "0x" . "0"x62 . ".." . "0x" . "F"x62; | |||
|
|
|||
| # prepare for making efilter. | |||
| my $foperand = "0x" . "F"x62; | |||
| my $bitwvalue = "0x" . "F"x62; | |||
| my $fvallist = "0x" . sprintf "%062d", 1; | |||
There was a problem hiding this comment.
fvallist => compvallist
t/long_query_detect_issue.t
Outdated
| @@ -42,13 +42,13 @@ sub do_btree_efilter { | |||
| $bkrange = "0x" . "0"x62 . ".." . "0x" . "F"x62; | |||
|
|
|||
| # prepare for making efilter. | |||
| my $foperand = "0x" . "F"x62; | |||
| my $bitwvalue = "0x" . "F"x62; | |||
| my $fvallist = "0x" . sprintf "%062d", 1; | |||
There was a problem hiding this comment.
fvallist => compvallist
| - [\<bitwop\> \<foperand\>] | ||
| bitwise/compare 연산을 취할 데이터의 length는 \<compvalue\>의 length로 한다. | ||
| 예를 들어, eflag 전체 데이터를 선택한다면, \<offset\>은 0이어야 하고 | ||
| \<compvalue\>의 length는 eflag 전체 데이터의 length와 동일하여야 한다. |
There was a problem hiding this comment.
offset 설명을 아래와 같이 합시다.
- eflag 값에서 bitwise/compare 연산을 취할 시작 offset을 바이트 단위로 나타낸다.
- offset과 bitwise/compare 연산을 취할 데이터 length의 합은 eflag 데이터의 length보다 작거나 같아야 한다.
- 예를 들어, eflag 전체 데이터와 비교한다면, <offset>은 0이어야 <compvalue>의 length는 eflag 전체 데이터의 length와 동일하여야 한다.
| \<fvalue\>는 eflag 부분 데이터에 대해 bitwise 연산을 취할 operand로 사용되며, | ||
| - 앞서 기술한 \<offset\>과 \<bitwop\>가 생략되면, eflag의 전체 데이터를 \<value\>로 변경한다. | ||
| 부분 변경을 위한 \<offset\>과 \<bitwop\>가 지정되면 | ||
| \<value\>는 eflag 부분 데이터에 대해 bitwise 연산을 취할 operand로 사용되며, |
jhpark816
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue
⌨️ What I did