Fix build #210
Open
Fix build #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop the build on first error, otherwise when libpcap failed to build we get the following libpcap not found error when linking the engine, which is a little confusing, /usr/bin/ld: cannot find /tmp/nfstream_build/usr/local/lib/libpcap.a: No such file or directory collect2: error: ld returned 1 exit status
There are incompatible API changes in DPDK that causes build errors. As we are not using dpdk, explicitly disable it.
gcc -fvisibility=hidden -fpic -I. -include rte_config.h -march=corei7 -mrtm -I/usr/include/libnl3 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -DBUILDING_PCAP -Dpcap_EXPORTS -DHAVE_CONFIG_H -g -O2 -c ./pcap-dpdk.c
./pcap-dpdk.c:202:18: error: ‘struct rte_eth_rxmode’ has no member named ‘split_hdr_size’
202 | .split_hdr_size = 0,
| ^~~~~~~~~~~~~~
./pcap-dpdk.c:205:28: error: ‘ETH_MQ_TX_NONE’ undeclared here (not in a function); did you mean ‘RTE_ETH_MQ_TX_NONE’?
205 | .mq_mode = ETH_MQ_TX_NONE,
| ^~~~~~~~~~~~~~
| RTE_ETH_MQ_TX_NONE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When an incompatible dpdk is installed, the build of libpcap fails. This PR fixes it.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Build it on Arch Linux (with dpdk package installed on system)
Test Configuration:
Checklist: