Content-Length: 258439 | pFad | http://github.com/nfx/slrp/pull/129

5E Refactor type names, move components out of util by SriramKeerthi · Pull Request #129 · nfx/slrp · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor type names, move components out of util #129

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Conversation

SriramKeerthi
Copy link
Contributor

No description provided.

return (
<li>
{link ? (
<a className="link-primary app-link" href={link.replace("$", Name)}>

Check failure

Code scanning / CodeQL

Incomplete string escaping or encoding

This replaces only the first occurrence of "$".
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #129 (50c3f83) into main (c1f73a5) will decrease coverage by 0.21%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
- Coverage   85.17%   84.97%   -0.21%     
==========================================
  Files          72       72              
  Lines        4479     4479              
==========================================
- Hits         3815     3806       -9     
- Misses        504      512       +8     
- Partials      160      161       +1     

see 2 files with indirect coverage changes

ui/src/Dashboard.tsx Outdated Show resolved Hide resolved
@SriramKeerthi
Copy link
Contributor Author

@nfx ready to review again

@nfx nfx merged commit 3a162dc into nfx:main Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/nfx/slrp/pull/129

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy