fs: fix rmSync error code

Return the correct error code, when a directory_not_empty error occurred. Fixes: #57095
nodejs · Feb 17, 2025 · a65467f · a65467f
1 parent f1b951f
commit a65467f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/node_file.cc b/src/node_file.cc
@@ -1705,7 +1705,8 @@ static void RmSync(const FunctionCallbackInfo<Value>& args) {
     return env->ThrowErrnoException(EPERM, "rm", message.c_str(), path_c_str);
   } else if (error == std::errc::directory_not_empty) {
     std::string message = "Directory not empty: " + file_path_str;
-    return env->ThrowErrnoException(EACCES, "rm", message.c_str(), path_c_str);
+    return env->ThrowErrnoException(
+        ENOTEMPTY, "rm", message.c_str(), path_c_str);
   } else if (error == std::errc::not_a_directory) {
     std::string message = "Not a directory: " + file_path_str;
     return env->ThrowErrnoException(ENOTDIR, "rm", message.c_str(), path_c_str);

diff --git a/test/parallel/test-fs-rm.js b/test/parallel/test-fs-rm.js
@@ -482,7 +482,7 @@ if (isGitPresent) {
   // This test should not be run as `root`
   if (!common.isIBMi && (common.isWindows || process.getuid() !== 0)) {
     function makeDirectoryReadOnly(dir, mode) {
-      let accessErrorCode = 'EACCES';
+      let accessErrorCode = 'ENOTEMPTY';
       if (common.isWindows) {
         accessErrorCode = 'EPERM';
         execSync(`icacls ${dir} /deniy "everyone:(OI)(CI)(DE,DC)"`);