src: replace NewFromUtf8 with OneByteString where appropriate #57096
+13
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
anonrig
approved these changes
Feb 16, 2025
src/spawn_sync.cc
Outdated
| String::NewFromUtf8(env()->isolate(), | ||
| signo_string(term_signal_)) | ||
| .ToLocalChecked()) | ||
| OneByteString(env()->isolate(), signo_string(term_signal_))) |
There was a problem hiding this comment.
Should we cache this signo_string() result in the future?
There was a problem hiding this comment.
I wouldn't think that is necessary.
aduh95
approved these changes
Feb 16, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57096 +/- ##
=======================================
Coverage 89.05% 89.06%
=======================================
Files 665 665
Lines 193299 193292 -7
Branches 37257 37254 -3
=======================================
+ Hits 172152 172155 +3
+ Misses 13841 13834 -7
+ Partials 7306 7303 -3
|
legendecas
approved these changes
Feb 17, 2025
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
added
the
author ready
jasnell
force-pushed
the
jasnell/use-onebytestring-where-appropriate
branch
from
ccf154e to
84e19d1
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.