build: bump supported macOS version to 13.5 #57115
Open
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macOS 11 is no longer supported by Apple since September 2023, and macOS 12 since September 2024 Let's not lock ourselves on already EoL versions for future Node.js 24 LTS. This also enables access to more C++20 features, in particular `std::format` (which requires at least 13.3).
|
Review requested:
|
nodejs-github-bot
added
build
|
@nodejs/tsc @nodejs/build @nodejs/platform-macos |
targos
added
the
semver-major
gengjiawen
approved these changes
Feb 18, 2025
github-actions
bot
removed
the
request-ci
joyeecheung
approved these changes
Feb 18, 2025
marco-ippolito
approved these changes
Feb 18, 2025
richardlau
approved these changes
Feb 18, 2025
BethGriggs
approved these changes
Feb 18, 2025
anonrig
approved these changes
Feb 18, 2025
|
Is this the last version we can bump it into or can we bump it higher? |
|
We can bump the minor higher if needed (up to 13.7). The major is still supported (probably until Sep 2025). |
UlisesGascon
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macOS 11 is no longer supported by Apple since September 2023, and macOS 12 since September 2024
Let's not lock ourselves on already EoL versions for future Node.js 24 LTS.
This also enables access to more C++20 features,
in particular
std::format(which requires at least 13.3).I chose 13.5 because it's the last one to provide a kernel upgrade, according to https://en.wikipedia.org/wiki/MacOS_Ventura#Release_history, but I'm happy to use another target as long as it's >=13.3.