Content-Length: 274648 | pFad | http://github.com/nodejs/node/pull/57132

D5 test: test-buffer-write.js: test each write throw case individually by nektro · Pull Request #57132 · nodejs/node · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: test-buffer-write.js: test each write throw case individually #57132

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: test-buffer-write.js: test each write throw case individually #57132

wants to merge 1 commit into from
+10 −0

Conversation

nektro
Copy link
Contributor

@nektro nektro commented Feb 18, 2025

as written, if buf.asciiWrite threw then none of the others would have been checked

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 18, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 18, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.03%. Comparing base (a724a9e) to head (ef7f173).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #57132      +/-   ##
==========================================
- Coverage   89.04%   89.03%   -0.01%     
==========================================
  Files         665      665              
  Lines      193401   193401              
  Branches    37283    37269      -14     
==========================================
- Hits       172207   172203       -4     
- Misses      13875    13881       +6     
+ Partials     7319     7317       -2

see 18 files with indirect coverage changes

@atlowChemi atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 19, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 19, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65312/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nektro @nodejs-github-bot @lpinca @cjihrig @atlowChemi








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/nodejs/node/pull/57132

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy